From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: skip fscounters comparisons when the scan is incomplete
Date: Fri, 14 Oct 2022 14:51:50 +1100 [thread overview]
Message-ID: <20221014035150.GL3600936@dread.disaster.area> (raw)
In-Reply-To: <166473480561.1083794.11478098043597895258.stgit@magnolia>
On Sun, Oct 02, 2022 at 11:20:05AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> If any part of the per-AG summary counter scan loop aborts without
> collecting all of the data we need, the scrubber's observation data will
> be invalid. Set the incomplete flag so that we abort the scrub without
> reporting false corruptions. Document the data dependency here too.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/scrub/fscounters.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
Looks good. Added comments are nice :)
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-10-14 3:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 18:20 [PATCHSET v23.1 0/2] xfs: enhance fs summary counter scrubber Darrick J. Wong
2022-10-02 18:20 ` [PATCH 1/2] xfs: skip fscounters comparisons when the scan is incomplete Darrick J. Wong
2022-10-14 3:51 ` Dave Chinner [this message]
2022-10-02 18:20 ` [PATCH 2/2] xfs: online checking of the free rt extent count Darrick J. Wong
2022-10-14 3:56 ` Dave Chinner
2022-10-14 21:46 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014035150.GL3600936@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox