From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11249C4332F for ; Fri, 14 Oct 2022 03:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbiJNDwJ (ORCPT ); Thu, 13 Oct 2022 23:52:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbiJNDv6 (ORCPT ); Thu, 13 Oct 2022 23:51:58 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4E47C96218 for ; Thu, 13 Oct 2022 20:51:53 -0700 (PDT) Received: from dread.disaster.area (pa49-181-106-210.pa.nsw.optusnet.com.au [49.181.106.210]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 7886B11017B0; Fri, 14 Oct 2022 14:51:51 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ojBji-001jkw-BZ; Fri, 14 Oct 2022 14:51:50 +1100 Date: Fri, 14 Oct 2022 14:51:50 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/2] xfs: skip fscounters comparisons when the scan is incomplete Message-ID: <20221014035150.GL3600936@dread.disaster.area> References: <166473480544.1083794.8963547317476704789.stgit@magnolia> <166473480561.1083794.11478098043597895258.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166473480561.1083794.11478098043597895258.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=6348dcd7 a=j6JUzzrSC7wlfFge/rmVbg==:117 a=j6JUzzrSC7wlfFge/rmVbg==:17 a=kj9zAlcOel0A:10 a=Qawa6l4ZSaYA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=b8JAYcqemDKF309umeEA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Oct 02, 2022 at 11:20:05AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > If any part of the per-AG summary counter scan loop aborts without > collecting all of the data we need, the scrubber's observation data will > be invalid. Set the incomplete flag so that we abort the scrub without > reporting false corruptions. Document the data dependency here too. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/scrub/fscounters.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) Looks good. Added comments are nice :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com