Re: [PATCH 4/9] xfs: use byte ranges for write cleanup ranges

Christoph Hellwig
2022-11-15T08:42:23Z

On Tue, Nov 15, 2022 at 12:30:38PM +1100, Dave Chinner wrote:
> +static int
> +xfs_buffered_write_delalloc_punch(
> + struct inode *inode,
> + loff_t start_byte,
> + loff_t end_byte)
> +{
> + struct xfs_mount *mp = XFS_M(inode->i_sb);
> + xfs_fileoff_t start_fsb = XFS_B_TO_FSBT(mp, start_byte);
> + xfs_fileoff_t end_fsb = XFS_B_TO_FSB(mp, end_byte);
> +
> + return xfs_bmap_punch_delalloc_range(XFS_I(inode), start_fsb,
> + end_fsb - start_fsb);
> +}

What is the reason to not switch xfs_bmap_punch_delalloc_range to
just take the byte range as discussed last round?