From: Andreas Gruenbacher <agruenba@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, cluster-devel@redhat.com
Subject: [RFC v3 0/7] Turn iomap_page_ops into iomap_folio_ops
Date: Fri, 16 Dec 2022 16:06:19 +0100 [thread overview]
Message-ID: <20221216150626.670312-1-agruenba@redhat.com> (raw)
This is an updated proposal for changing the iomap page_ops operations
to make them more flexible so that they better suite the filesystem
needs. It closes a race on gfs2 and cleans up the recent iomap changes
merged in the following upstream commit:
87be949912ee ("Merge tag 'xfs-6.2-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux")
The first patch introduces a folio_may_straddle_isize() helper as a
replacement for pagecache_isize_extended() when we have a locked folio.
This still needs independent verification, but it looks like a
worthwhile improvement to me. I've left it in this patch queue for now,
but I can moved out of the way if prefered.
Any thoughts?
Thanks,
Andreas
Andreas Gruenbacher (7):
fs: Add folio_may_straddle_isize helper
iomap: Add iomap_folio_done helper
iomap/gfs2: Unlock and put folio in page_done handler
iomap: Add iomap_folio_prepare helper
iomap: Get page in page_prepare handler
iomap/xfs: Eliminate the iomap_valid handler
iomap: Rename page_ops to folio_ops
fs/buffer.c | 5 +--
fs/ext4/inode.c | 13 +++---
fs/gfs2/bmap.c | 43 +++++++++++++------
fs/iomap/buffered-io.c | 95 +++++++++++++++++++++---------------------
fs/xfs/xfs_iomap.c | 42 +++++++++++++------
include/linux/iomap.h | 46 +++++++-------------
include/linux/mm.h | 2 +
mm/truncate.c | 35 ++++++++++++++++
8 files changed, 169 insertions(+), 112 deletions(-)
--
2.38.1
next reply other threads:[~2022-12-16 15:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 15:06 Andreas Gruenbacher [this message]
2022-12-16 15:06 ` [RFC v3 1/7] fs: Add folio_may_straddle_isize helper Andreas Gruenbacher
2022-12-23 14:56 ` Christoph Hellwig
2022-12-23 22:04 ` Andreas Grünbacher
2022-12-24 7:21 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 2/7] iomap: Add iomap_folio_done helper Andreas Gruenbacher
2022-12-23 15:02 ` Christoph Hellwig
2022-12-23 20:54 ` Andreas Grünbacher
2022-12-24 7:22 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 3/7] iomap/gfs2: Unlock and put folio in page_done handler Andreas Gruenbacher
2022-12-23 15:03 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 4/7] iomap: Add iomap_folio_prepare helper Andreas Gruenbacher
2022-12-23 15:04 ` Christoph Hellwig
2022-12-23 21:05 ` Andreas Grünbacher
2022-12-24 7:23 ` Christoph Hellwig
2022-12-25 9:12 ` Matthew Wilcox
2022-12-28 15:55 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 5/7] iomap: Get page in page_prepare handler Andreas Gruenbacher
2022-12-16 16:30 ` Matthew Wilcox
2022-12-16 17:15 ` Andreas Gruenbacher
2022-12-23 15:07 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 6/7] iomap/xfs: Eliminate the iomap_valid handler Andreas Gruenbacher
2022-12-23 15:10 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 7/7] iomap: Rename page_ops to folio_ops Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 0/7] Turn iomap_page_ops into iomap_folio_ops Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 1/7] fs: Add folio_may_straddle_isize helper Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 2/7] iomap: Add iomap_folio_done helper Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 3/7] iomap/gfs2: Unlock and put folio in page_done handler Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 4/7] iomap: Add iomap_folio_prepare helper Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 5/7] iomap/gfs2: Get page in page_prepare handler Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 6/7] iomap/xfs: Eliminate the iomap_valid handler Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 7/7] iomap: Rename page_ops to folio_ops Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216150626.670312-1-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox