From: Dave Chinner <david@fromorbit.com>
To: Csaba Henk <chenk@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfsdocs: add epub output
Date: Thu, 12 Jan 2023 09:10:27 +1100 [thread overview]
Message-ID: <20230111221027.GC360264@dread.disaster.area> (raw)
In-Reply-To: <20230111081557.rpmcmkkat7gagqup@nixos>
On Wed, Jan 11, 2023 at 09:15:57AM +0100, Csaba Henk wrote:
> ---
> .gitignore | 1 +
> admin/Makefile | 13 +++++++++++--
> admin/XFS_Performance_Tuning/Makefile | 13 +++++++++++--
> design/Makefile | 13 +++++++++++--
> design/XFS_Filesystem_Structure/Makefile | 13 +++++++++++--
> 5 files changed, 45 insertions(+), 8 deletions(-)
The change looks fine, but why do we need to build documentation in
epub format? Empty commit messages are generally considered a bad
thing - the commit message should explain to us why building epub
format documentation is desired, what problem it solves, what new
dependencies it introduces (e.g. build tools), how we should
determine that the generated documentation is good, etc so that have
some basis from which to evaluate the change from.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-01-11 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 8:15 [PATCH] xfsdocs: add epub output Csaba Henk
2023-01-11 22:10 ` Dave Chinner [this message]
2023-01-12 1:44 ` Csaba Henk
2023-01-12 1:56 ` Darrick J. Wong
2023-01-12 8:40 ` Csaba Henk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111221027.GC360264@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chenk@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox