Re: [PATCH 00/42] xfs: per-ag centric allocation alogrithms

Dave Chinner
2023-02-06T23:14:05Z

On Wed, Feb 01, 2023 at 04:14:21PM -0800, Darrick J. Wong wrote:
> On Thu, Jan 19, 2023 at 09:44:23AM +1100, Dave Chinner wrote:
> > This series continues the work towards making shrinking a filesystem
> > possible. We need to be able to stop operations from taking place
> > on AGs that need to be removed by a shrink, so before shrink can be
> > implemented we need to have the infrastructure in place to prevent
> > incursion into AGs that are going to be, or are in the process, of
> > being removed from active duty.
> >
> > The focus of this is making operations that depend on access to AGs
> > use the perag to access and pin the AG in active use, thereby
> > creating a barrier we can use to delay shrink until all active uses
> > of an AG have been drained and new uses are prevented.
> >
> > This series starts by fixing some existing issues that are exposed
> > by changes later in the series. They stand alone, so can be picked
> > up independently of the rest of this patchset.
>
> Hmm if I had to pick up only the bugfixes, which patches are those?
> Patches 1-3 look like bug fixes, 4-6 might be but might not be?

1-3 are bug fixes. 4-6 are dependent on 1 and they expand the range
of AGs that can be allocated in when a single AG is at ENOSPC. We
have had users reporting premature ENOSPC being reported to
applications in this exact situation in the past (maybe half a dozen
in the past decade or so?), so it is a bug fix of sorts. It's not a
critical bug fix, though, as it's not a common problem.

.....
>
> For all the patches that I have not sent replies to,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> IIRC that's patches 1-6, 8, 10-13, 16, 18-19, 24-27, and 30-40.

Thanks!

-Dave.
--
Dave Chinner
david@fromorbit.com