[PATCH 36/42] xfs: remove xfs_filestream_select_ag() longest extent check

Dave Chinner
2023-01-18T22:48:10Z

Picking a new AG checks the longest free extent in the AG is valid,
so there's no need to repeat the check in
xfs_filestream_select_ag(). Remove it.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/xfs_filestream.c | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/fs/xfs/xfs_filestream.c b/fs/xfs/xfs_filestream.c
index 713766729dcf..95e28aae35ab 100644
--- a/fs/xfs/xfs_filestream.c
+++ b/fs/xfs/xfs_filestream.c
@@ -276,7 +276,7 @@ xfs_filestream_select_ag(
xfs_agnumber_t agno = NULLAGNUMBER;
struct xfs_mru_cache_elem *mru;
int flags = 0;
- int error;
+ int error = 0;

args->total = ap->total;
*blen = 0;
@@ -351,27 +351,11 @@ xfs_filestream_select_ag(
goto out_error;
if (agno == NULLAGNUMBER) {
agno = 0;
- goto out_irele;
- }
-
- pag = xfs_perag_grab(mp, agno);
- if (!pag)
- goto out_irele;
-
- error = xfs_bmap_longest_free_extent(pag, args->tp, blen);
- xfs_perag_rele(pag);
- if (error) {
- if (error != -EAGAIN)
- goto out_error;
*blen = 0;
}

-out_irele:
- xfs_irele(pip);
out_select:
ap->blkno = XFS_AGB_TO_FSB(mp, agno, 0);
- return 0;
-
out_error:
xfs_irele(pip);
return error;
--
2.39.0