From: Dave Chinner <david@fromorbit.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
djwong@kernel.org, dan.j.williams@intel.com, hch@infradead.org,
jane.chu@oracle.com, akpm@linux-foundation.org,
willy@infradead.org
Subject: Re: [PATCH v10 2/3] fs: introduce super_drop_pagecache()
Date: Tue, 21 Feb 2023 08:25:06 +1100 [thread overview]
Message-ID: <20230220212506.GS360264@dread.disaster.area> (raw)
In-Reply-To: <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com>
On Fri, Feb 17, 2023 at 02:48:31PM +0000, Shiyang Ruan wrote:
> xfs_notify_failure.c requires a method to invalidate all dax mappings.
> drop_pagecache_sb() can do this but it is a static function and only
> build with CONFIG_SYSCTL. Now, move its implementation into super.c and
> call it super_drop_pagecache(). Use its second argument as invalidator
> so that we can choose which invalidate method to use.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
I got no repsonse last time, so I'll just post a link to the
concerns I stated about this:
https://lore.kernel.org/linux-xfs/20230205215000.GT360264@dread.disaster.area/
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-02-20 21:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 14:48 [PATCH v10 0/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind Shiyang Ruan
2023-02-17 14:48 ` [PATCH v10 1/3] xfs: fix the calculation of length and end Shiyang Ruan
2023-02-17 14:48 ` [PATCH v10 2/3] fs: introduce super_drop_pagecache() Shiyang Ruan
2023-02-17 16:14 ` Matthew Wilcox
2023-02-18 1:16 ` Shiyang Ruan
2023-02-18 18:27 ` Matthew Wilcox
2023-02-20 9:39 ` Shiyang Ruan
2023-02-20 9:45 ` Shiyang Ruan
2023-02-20 21:25 ` Dave Chinner [this message]
2023-02-21 1:57 ` Shiyang Ruan
2023-02-26 23:50 ` Dave Chinner
2023-02-17 14:48 ` [PATCH v10 3/3] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind Shiyang Ruan
2023-02-27 0:07 ` Dave Chinner
2023-02-27 10:06 ` Shiyang Ruan
2023-03-21 10:59 ` Shiyang Ruan
2023-03-24 9:49 ` Shiyang Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220212506.GS360264@dread.disaster.area \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox