From: "Darrick J. Wong" <djwong@kernel.org>
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH] xfs_db: fix complaints about unsigned char casting
Date: Tue, 14 Mar 2023 18:01:10 -0700 [thread overview]
Message-ID: <20230315010110.GD11376@frogsfrogsfrogs> (raw)
From: Darrick J. Wong <djwong@kernel.org>
Make the warnings about signed/unsigned char pointer casting go away.
For printing dirent names it doesn't matter at all.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
db/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/db/namei.c b/db/namei.c
index 00e8c8dc6d5..063721ca98f 100644
--- a/db/namei.c
+++ b/db/namei.c
@@ -98,7 +98,7 @@ path_navigate(
for (i = 0; i < dirpath->depth; i++) {
struct xfs_name xname = {
- .name = dirpath->path[i],
+ .name = (unsigned char *)dirpath->path[i],
.len = strlen(dirpath->path[i]),
};
@@ -250,7 +250,7 @@ dir_emit(
uint8_t dtype)
{
char *display_name;
- struct xfs_name xname = { .name = name };
+ struct xfs_name xname = { .name = (unsigned char *)name };
const char *dstr = get_dstr(mp, dtype);
xfs_dahash_t hash;
bool good;
next reply other threads:[~2023-03-15 1:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yd5KB_VD7Oe2M-1JTpW8yKsKQ7SaQV9hnFIguCvPI-CuHqrQHOECUVh2Ar9oGpOi5jLK1LKpQ0D_NqN-kz5eyw==@protonmail.internalid>
2023-03-15 1:01 ` Darrick J. Wong [this message]
2023-03-17 10:25 ` [PATCH] xfs_db: fix complaints about unsigned char casting Carlos Maiolino
2023-03-17 10:43 ` Alan Huang
2023-03-17 20:29 ` Darrick J. Wong
2023-03-18 13:59 ` Alan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315010110.GD11376@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox