From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F360C76196 for ; Wed, 29 Mar 2023 01:02:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjC2BC5 (ORCPT ); Tue, 28 Mar 2023 21:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjC2BC4 (ORCPT ); Tue, 28 Mar 2023 21:02:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD9F9272E; Tue, 28 Mar 2023 18:02:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 22318B81F81; Wed, 29 Mar 2023 01:02:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D30C4C433EF; Wed, 29 Mar 2023 01:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680051766; bh=ESosFi3s37lb372D9H7OIW0PzbS2SAzMSzj4OGLIkD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fgbo7i1Wcvok25OISExRLb88d/V7WdhbQBkmbaS8hQhob38S2A1s01QCy5gKt8bPW 6q0DPLHL8Qx6mESu+tmuKwQPcNNM7oA4r8gM3cx46yUIY3vSnbuBJ88nY9/otx7AkA 9zh+Tno26DPXfKODb3CV3ZbH7ctVe4LUQeUt6b7TBEPe7RSTcrQj8T4g8Nm8my5lm0 jcUohizO97uhcYznxfBCygchjSPhaxTbYjTPSikk2lwil99YtaLi7wvbMtuqXE0rzV oE9VSVljG2bd1A95n+1q5KpPOxNf9wUMVCSqDf9iIWtpBg/pz+lUp2mA/b/Lpr2Lnb ijOV/uQjJ5V7w== Date: Tue, 28 Mar 2023 18:02:46 -0700 From: "Darrick J. Wong" To: Ye Bin Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, yebin10@huawei.com Subject: Re: [PATCH v2] xfs: fix BUG_ON in xfs_getbmap() Message-ID: <20230329010246.GA4126677@frogsfrogsfrogs> References: <20230328142129.2636535-1-yebin@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328142129.2636535-1-yebin@huaweicloud.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Mar 28, 2023 at 10:21:29PM +0800, Ye Bin wrote: > From: Ye Bin > > There's issue as follows: > XFS: Assertion failed: (bmv->bmv_iflags & BMV_IF_DELALLOC) != 0, file: fs/xfs/xfs_bmap_util.c, line: 329 > ------------[ cut here ]------------ > kernel BUG at fs/xfs/xfs_message.c:102! > invalid opcode: 0000 [#1] PREEMPT SMP KASAN > CPU: 1 PID: 14612 Comm: xfs_io Not tainted 6.3.0-rc2-next-20230315-00006-g2729d23ddb3b-dirty #422 > RIP: 0010:assfail+0x96/0xa0 > RSP: 0018:ffffc9000fa178c0 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: 0000000000000001 RCX: ffff888179a18000 > RDX: 0000000000000000 RSI: ffff888179a18000 RDI: 0000000000000002 > RBP: 0000000000000000 R08: ffffffff8321aab6 R09: 0000000000000000 > R10: 0000000000000001 R11: ffffed1105f85139 R12: ffffffff8aacc4c0 > R13: 0000000000000149 R14: ffff888269f58000 R15: 000000000000000c > FS: 00007f42f27a4740(0000) GS:ffff88882fc00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000b92388 CR3: 000000024f006000 CR4: 00000000000006e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > xfs_getbmap+0x1a5b/0x1e40 > xfs_ioc_getbmap+0x1fd/0x5b0 > xfs_file_ioctl+0x2cb/0x1d50 > __x64_sys_ioctl+0x197/0x210 > do_syscall_64+0x39/0xb0 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > Above issue may happen as follows: > ThreadA ThreadB > do_shared_fault > __do_fault > xfs_filemap_fault > __xfs_filemap_fault > filemap_fault > xfs_ioc_getbmap -> Without BMV_IF_DELALLOC flag > xfs_getbmap > xfs_ilock(ip, XFS_IOLOCK_SHARED); > filemap_write_and_wait > do_page_mkwrite > xfs_filemap_page_mkwrite > __xfs_filemap_fault > xfs_ilock(XFS_I(inode), XFS_MMAPLOCK_SHARED); > iomap_page_mkwrite > ... > xfs_buffered_write_iomap_begin > xfs_bmapi_reserve_delalloc -> Allocate delay extent > xfs_ilock_data_map_shared(ip) > xfs_getbmap_report_one > ASSERT((bmv->bmv_iflags & BMV_IF_DELALLOC) != 0) > -> trigger BUG_ON > > As xfs_filemap_page_mkwrite() only hold XFS_MMAPLOCK_SHARED lock, there's > small window mkwrite can produce delay extent after file write in xfs_getbmap(). > To solve above issue, just skip delalloc extents. > > Signed-off-by: Ye Bin > --- > fs/xfs/xfs_bmap_util.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c > index a09dd2606479..d2a109ceb922 100644 > --- a/fs/xfs/xfs_bmap_util.c > +++ b/fs/xfs/xfs_bmap_util.c > @@ -322,7 +322,8 @@ xfs_getbmap_report_one( > * extents. > */ > if (got->br_startoff < XFS_B_TO_FSB(ip->i_mount, XFS_ISIZE(ip))) > - ASSERT((bmv->bmv_iflags & BMV_IF_DELALLOC) != 0); > + if (!(bmv->bmv_iflags & BMV_IF_DELALLOC)) > + return 0; Why only hide the delalloc mapping if it's below EOF? --D > > p->bmv_oflags |= BMV_OF_DELALLOC; > p->bmv_block = -2; > -- > 2.31.1 >