* [PATCH] xfs/517: add missing freeze command
@ 2023-04-13 0:10 Darrick J. Wong
2023-04-13 9:39 ` Andrey Albershteyn
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2023-04-13 0:10 UTC (permalink / raw)
To: zlang; +Cc: linux-xfs, fstests, guan
From: Darrick J. Wong <djwong@kernel.org>
This test is supposed to race fsstress, fsmap, and freezing for a while,
but when we converted it to use _scratch_xfs_stress_scrub, the freeze
loop fell off by accident. Add it back.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
tests/xfs/517 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/517 b/tests/xfs/517
index 4481ba41da..68438e544e 100755
--- a/tests/xfs/517
+++ b/tests/xfs/517
@@ -32,7 +32,7 @@ _require_xfs_stress_scrub
_scratch_mkfs > "$seqres.full" 2>&1
_scratch_mount
-_scratch_xfs_stress_scrub -i 'fsmap -v'
+_scratch_xfs_stress_scrub -f -i 'fsmap -v'
# success, all done
echo "Silence is golden"
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/517: add missing freeze command
2023-04-13 0:10 [PATCH] xfs/517: add missing freeze command Darrick J. Wong
@ 2023-04-13 9:39 ` Andrey Albershteyn
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Albershteyn @ 2023-04-13 9:39 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: zlang, linux-xfs, fstests, guan
On Wed, Apr 12, 2023 at 05:10:43PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This test is supposed to race fsstress, fsmap, and freezing for a while,
> but when we converted it to use _scratch_xfs_stress_scrub, the freeze
> loop fell off by accident. Add it back.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> tests/xfs/517 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/517 b/tests/xfs/517
> index 4481ba41da..68438e544e 100755
> --- a/tests/xfs/517
> +++ b/tests/xfs/517
> @@ -32,7 +32,7 @@ _require_xfs_stress_scrub
>
> _scratch_mkfs > "$seqres.full" 2>&1
> _scratch_mount
> -_scratch_xfs_stress_scrub -i 'fsmap -v'
> +_scratch_xfs_stress_scrub -f -i 'fsmap -v'
>
> # success, all done
> echo "Silence is golden"
>
Looks good to me
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>
--
- Andrey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-13 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 0:10 [PATCH] xfs/517: add missing freeze command Darrick J. Wong
2023-04-13 9:39 ` Andrey Albershteyn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox