From: "Darrick J. Wong" <djwong@kernel.org>
To: ye.xingchen@zte.com.cn
Cc: dchinner@redhat.com, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: scrub: remove duplicate include headers
Date: Mon, 17 Apr 2023 17:08:13 -0700 [thread overview]
Message-ID: <20230418000813.GB360889@frogsfrogsfrogs> (raw)
In-Reply-To: <202304171613075788124@zte.com.cn>
On Mon, Apr 17, 2023 at 04:13:07PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> xfs_trans_resv.h and xfs_mount.h are included more than once.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
> fs/xfs/scrub/health.c | 2 --
> fs/xfs/scrub/refcount.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/xfs/scrub/health.c b/fs/xfs/scrub/health.c
> index d2b2a1cb6533..66e99b0f6049 100644
> --- a/fs/xfs/scrub/health.c
> +++ b/fs/xfs/scrub/health.c
> @@ -7,8 +7,6 @@
> #include "xfs_fs.h"
> #include "xfs_shared.h"
> #include "xfs_format.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
> #include "xfs_btree.h"
> #include "xfs_trans_resv.h"
> #include "xfs_mount.h"
The convention (AFAICT) for include order is xfs_trans_resv -> xfs_mount
-> xfs_btree.h...
> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index ed5eb367ce49..04d216261f36 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c
Please check the list before sending duplicate diffs.
--D
> @@ -7,8 +7,6 @@
> #include "xfs_fs.h"
> #include "xfs_shared.h"
> #include "xfs_format.h"
> -#include "xfs_trans_resv.h"
> -#include "xfs_mount.h"
> #include "xfs_btree.h"
> #include "xfs_rmap.h"
> #include "xfs_refcount.h"
> --
> 2.25.1
prev parent reply other threads:[~2023-04-18 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 8:13 [PATCH] xfs: scrub: remove duplicate include headers ye.xingchen
2023-04-17 21:45 ` Dave Chinner
2023-04-18 0:08 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418000813.GB360889@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox