Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	xfs <linux-xfs@vger.kernel.org>,
	Chandan Babu R <chandan.babu@oracle.com>,
	Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH] xfs: drop EXPERIMENTAL tag for large extent counts
Date: Fri, 21 Apr 2023 09:24:26 +1000	[thread overview]
Message-ID: <20230420232426.GA3223426@dread.disaster.area> (raw)
In-Reply-To: <20230420151000.GH360889@frogsfrogsfrogs>

On Thu, Apr 20, 2023 at 08:10:00AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This feature has been baking in upstream for ~10mo with no bug reports.
> It seems to work fine here, let's get rid of the scary warnings?

Are you proposing this for the 6.4 cycle (next weeks merge window)
or for the cycle after this?  I don't see an issue with removing the
experimental tag, but I do think it's a bit late for this cycle....

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  fs/xfs/xfs_super.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 4d2e87462ac4..dc13ff4ea25e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
>  		goto out_filestream_unmount;
>  	}
>  
> -	if (xfs_has_large_extent_counts(mp))
> -		xfs_warn(mp,
> -	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
> -

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2023-04-20 23:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20 15:10 [PATCH] xfs: drop EXPERIMENTAL tag for large extent counts Darrick J. Wong
2023-04-20 23:24 ` Dave Chinner [this message]
2023-04-27 19:01   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420232426.GA3223426@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=chandan.babu@oracle.com \
    --cc=cmaiolino@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox