From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/9] block: introduce holder ops
Date: Tue, 9 May 2023 15:35:01 +0200 [thread overview]
Message-ID: <20230509133501.GD841@lst.de> (raw)
In-Reply-To: <20230505185119.GI15394@frogsfrogsfrogs>
On Fri, May 05, 2023 at 11:51:19AM -0700, Darrick J. Wong wrote:
> Fun question: What happens when the swap disk falls off the bus?
Your system is toast.
> > - if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev)))
> > + if (IS_ERR(blkdev_get_by_dev(bdev->bd_dev, mode | FMODE_EXCL, &bdev,
> > + NULL)))
> > return -EBUSY;
> > ret = set_blocksize(bdev, n);
> > blkdev_put(bdev, mode | FMODE_EXCL);
>
> Somewhat related question: Should we allow userspace to initiate a fs
> shutdown through the block device? Let's say you're preparing to yank
> /dev/sda and want to kill anything attached to it or its partitions?
> Without having to walk through however many mount namespaces there are
> to find the mountpoints?
That's kinda what we're doing here. Or do you mean even more advanced
notice by having another callout before stopping I/O so that we could
write out all log buffers? It's probably doable, but I'm not convinced
that this use case is worth maintaining and testing the kernel code for
it.
next prev parent reply other threads:[~2023-05-09 13:35 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 17:51 introduce bdev holder ops and a file system shutdown method Christoph Hellwig
2023-05-05 17:51 ` [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
2023-05-09 13:35 ` Christoph Hellwig
2023-05-05 17:51 ` [PATCH 2/9] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
2023-05-07 19:05 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 3/9] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
2023-05-07 19:08 ` Jan Kara
2023-05-16 16:29 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 4/9] block: turn bdev_lock into a mutex Christoph Hellwig
2023-05-07 19:09 ` Jan Kara
2023-05-16 16:24 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 5/9] block: introduce holder ops Christoph Hellwig
2023-05-05 18:51 ` Darrick J. Wong
2023-05-09 13:35 ` Christoph Hellwig [this message]
2023-05-09 22:19 ` Dave Chinner
2023-05-10 1:38 ` Darrick J. Wong
2023-05-10 15:13 ` Christoph Hellwig
2023-05-07 19:12 ` Jan Kara
2023-05-16 11:02 ` Ming Lei
2023-05-16 14:36 ` Darrick J. Wong
2023-05-17 7:29 ` Christoph Hellwig
2023-05-16 16:00 ` Christian Brauner
2023-05-17 7:30 ` Christoph Hellwig
2023-05-17 7:57 ` Christian Brauner
2023-05-17 8:06 ` Christoph Hellwig
2023-05-17 8:42 ` Christian Brauner
2023-05-17 12:02 ` Christoph Hellwig
2023-05-17 13:14 ` Christian Brauner
2023-05-17 14:26 ` Christoph Hellwig
2023-05-18 8:13 ` Christian Brauner
2023-05-18 13:12 ` Christoph Hellwig
2023-05-18 13:13 ` Christoph Hellwig
2023-05-18 13:56 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 6/9] block: add a mark_dead holder operation Christoph Hellwig
2023-05-05 18:37 ` Darrick J. Wong
2023-05-09 13:30 ` Christoph Hellwig
2023-05-07 19:19 ` Jan Kara
2023-05-09 13:32 ` Christoph Hellwig
2023-05-16 16:17 ` Christian Brauner
2023-05-05 17:51 ` [PATCH 7/9] fs: add a method to shut down the file system Christoph Hellwig
2023-05-05 18:39 ` Darrick J. Wong
2023-05-07 19:20 ` Jan Kara
2023-05-16 16:20 ` Christian Brauner
2023-05-17 7:27 ` Christoph Hellwig
2023-05-05 17:51 ` [PATCH 8/9] xfs: wire up sops->shutdown Christoph Hellwig
2023-05-05 18:23 ` Darrick J. Wong
2023-05-09 13:28 ` Christoph Hellwig
2023-05-05 17:51 ` [PATCH 9/9] xfs: wire up the ->mark_dead holder operation for log and RT devices Christoph Hellwig
2023-05-05 18:32 ` Darrick J. Wong
2023-05-08 15:20 ` introduce bdev holder ops and a file system shutdown method Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509133501.GD841@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).