From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168D9C77B7C for ; Tue, 9 May 2023 13:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235013AbjEINft (ORCPT ); Tue, 9 May 2023 09:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234575AbjEINfs (ORCPT ); Tue, 9 May 2023 09:35:48 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2073E61; Tue, 9 May 2023 06:35:47 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id B2C446732A; Tue, 9 May 2023 15:35:44 +0200 (CEST) Date: Tue, 9 May 2023 15:35:44 +0200 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Jens Axboe , Al Viro , Christian Brauner , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Message-ID: <20230509133544.GE841@lst.de> References: <20230505175132.2236632-1-hch@lst.de> <20230505175132.2236632-2-hch@lst.de> <20230507190811.qbll5r3jsx35curi@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230507190811.qbll5r3jsx35curi@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, May 07, 2023 at 09:08:11PM +0200, Jan Kara wrote: > I'm somewhat wondering about the lost notification from > blk_mark_disk_dead(). E.g. DM uses blk_mark_disk_dead() so if some udev > script depends on the event when DM device gets destroyed, we would break > it? Maybe. We'll probably find out..