From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7C6C77B7C for ; Fri, 12 May 2023 06:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239902AbjELGCV (ORCPT ); Fri, 12 May 2023 02:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239955AbjELGCT (ORCPT ); Fri, 12 May 2023 02:02:19 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9E1249F9 for ; Thu, 11 May 2023 23:02:08 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-5304d0d1eddso2047961a12.2 for ; Thu, 11 May 2023 23:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1683871328; x=1686463328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KiPZR3DSGJ67e3ukh6EWttwadtz/ZpMiir8Rx/LMdYI=; b=ksyq0ACA9mQgupqCDoZo3U6Mmi55g+yPJ1wGysXo9dObFyntRtLjEvxSEYjMe8F74T gt5BwUBj45RBFTqMppsiksXl4jp240Xm/1OoSru4q7cTY7q5CD3UR7I2Yn9LieMAq3sc RwB9YWEHDucRoxemskt8phC9PzO51eaQus3v/wmeU5d7OlOLfbDlBVQM0yZyQPeBXKIY enksV9p0aeSmBN76eM9ISpO2juXIvH29ku360voYQTSMzT/kobWuiYHbfQliwuTKdVm9 A0XJXVj34S4Eg5+EmY98JFVGnKPnaj4CsZxGtgY3TXH7O4f9tA+Hf2zCcHDebsyb4yVD dIbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683871328; x=1686463328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KiPZR3DSGJ67e3ukh6EWttwadtz/ZpMiir8Rx/LMdYI=; b=acDkVcYVCdJWcMBEX75606Mjv0s8aN5WqmZBJyIyj70qCZqZptCRMqfOrr12sSAyVf ZnNj4/BCtHis2jfEnPNpnqNbUUKILlZPi4qu8u8b6T7Uyimk0yNS+LqJjoABatF6qqjU Ijo2FbdnTaXtdbHy6JePfT+y+tat74k3APvd76irFHf6TyW8M74/jgN4F+bNFuFtPD1G 6ATcnyNJvDEf+R6L7oEAGKcQ/JLIAbKuFCqxf/PK1cGll9NYWtZAVPg26P7MnC/XQDCf jkPHKLBi4I50sjtvKU+Gjf+LdjdMXiLMgPGJHvKen0+AwcTq7GvBnz0pdJPUPN3+ESTN W0fQ== X-Gm-Message-State: AC+VfDxTHN4XWVNlaWqVuTBR6jGrBgF+OSk9edSnBFJJucdBt8ApyHEe 9rO4l+nF5loYVYrRd26v8M/OJQ== X-Google-Smtp-Source: ACHHUZ4/v7ftMoPb3vohN9jQoEwLUcKW7f98bDDigmTq4AQHvLpC5uwcquRLZYeCEIEJeLSBhkBB0w== X-Received: by 2002:a17:902:ee89:b0:1a6:74f6:fa92 with SMTP id a9-20020a170902ee8900b001a674f6fa92mr25067340pld.19.1683871328463; Thu, 11 May 2023 23:02:08 -0700 (PDT) Received: from dread.disaster.area (pa49-181-88-204.pa.nsw.optusnet.com.au. [49.181.88.204]) by smtp.gmail.com with ESMTPSA id l6-20020a170902d34600b001a6ed2d0ef8sm6950230plk.273.2023.05.11.23.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 23:02:07 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pxLqu-00EIdU-Sp; Fri, 12 May 2023 16:02:04 +1000 Date: Fri, 12 May 2023 16:02:04 +1000 From: Dave Chinner To: "renlei1@chinatelecom.cn" Cc: "Darrick J. Wong" , linux-xfs , linux-kernel Subject: Re: Re: [PATCH] xfs: xfs_nfs_get_inode support zero generation Message-ID: <20230512060204.GC3223426@dread.disaster.area> References: <1683800241-14488-1-git-send-email-renlei1@chinatelecom.cn> <20230511232206.GG858799@frogsfrogsfrogs> <20230512020009.GB3223426@dread.disaster.area> <2023051210532845432129@chinatelecom.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023051210532845432129@chinatelecom.cn> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, May 12, 2023 at 10:53:29AM +0800, renlei1@chinatelecom.cn wrote: > Yup, gen is 0 for the inodes created by libxfs, such as rootino, rbmino, rsumino. > but those inodes will never be freed, and gen will always zero. Yes, but why does that even matter for file handle verification? > so I think bypass the verification if gen==0 is still valid. Did you think about what happens when an inode->gen overflows from 0xffffffff to 0 as part of a normal unlink/create cycle? -Dave. -- Dave Chinner david@fromorbit.com