public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 3/4] xfs: defered work could create precommits
Date: Wed, 17 May 2023 10:04:48 +1000	[thread overview]
Message-ID: <20230517000449.3997582-4-david@fromorbit.com> (raw)
In-Reply-To: <20230517000449.3997582-1-david@fromorbit.com>

From: Dave Chinner <dchinner@redhat.com>

To fix a AGI-AGF-inode cluster buffer deadlock, we need to move
inode cluster buffer oeprations to the ->iop_precommit() method.
However, this means that deferred operations can require precommits
to be run on the final transaction that the deferred ops pass back
to xfs_trans_commit() context. This will be exposed by attribute
handling, in that the last changes to the inode in the attr set
state machine "disappear" because the precommit operation is not run.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 fs/xfs/xfs_trans.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
index 8afc0c080861..664084509af5 100644
--- a/fs/xfs/xfs_trans.c
+++ b/fs/xfs/xfs_trans.c
@@ -970,6 +970,11 @@ __xfs_trans_commit(
 		error = xfs_defer_finish_noroll(&tp);
 		if (error)
 			goto out_unreserve;
+
+		/* Run precomits from final tx in defer chain */
+		error = xfs_trans_run_precommits(tp);
+		if (error)
+			goto out_unreserve;
 	}
 
 	/*
-- 
2.40.1


  parent reply	other threads:[~2023-05-17  0:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  0:04 xfs: bug fixes for 6.4-rcX Dave Chinner
2023-05-17  0:04 ` [PATCH 1/4] xfs: buffer pins need to hold a buffer reference Dave Chinner
2023-05-17  1:26   ` Darrick J. Wong
2023-05-17 12:58   ` Christoph Hellwig
2023-05-17 22:24     ` Dave Chinner
2023-05-17  0:04 ` [PATCH 2/4] xfs: restore allocation trylock iteration Dave Chinner
2023-05-17  1:11   ` Darrick J. Wong
2023-05-17 12:59   ` Christoph Hellwig
2023-05-17  0:04 ` Dave Chinner [this message]
2023-05-17  1:20   ` [PATCH 3/4] xfs: defered work could create precommits Darrick J. Wong
2023-05-17  1:44     ` Dave Chinner
2023-06-01 15:01   ` Christoph Hellwig
2023-05-17  0:04 ` [PATCH 4/4] xfs: fix AGF vs inode cluster buffer deadlock Dave Chinner
2023-05-17  1:26   ` Darrick J. Wong
2023-05-17  1:47     ` Dave Chinner
2023-06-01  1:51     ` Dave Chinner
2023-06-01 14:38       ` Darrick J. Wong
2023-06-01 15:12   ` Christoph Hellwig
2023-06-25  2:58   ` Matthew Wilcox
2023-06-25 22:34     ` Dave Chinner
2023-05-17  7:07 ` xfs: bug fixes for 6.4-rcX Amir Goldstein
2023-05-17 11:34   ` Dave Chinner
2023-05-17 12:48     ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517000449.3997582-4-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox