From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19CB6C77B75 for ; Wed, 17 May 2023 07:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbjEQHbb (ORCPT ); Wed, 17 May 2023 03:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbjEQHag (ORCPT ); Wed, 17 May 2023 03:30:36 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D1981AE; Wed, 17 May 2023 00:30:35 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id B969E68C4E; Wed, 17 May 2023 09:30:32 +0200 (CEST) Date: Wed, 17 May 2023 09:30:31 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Al Viro , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 5/9] block: introduce holder ops Message-ID: <20230517073031.GF27026@lst.de> References: <20230505175132.2236632-1-hch@lst.de> <20230505175132.2236632-6-hch@lst.de> <20230516-kommode-weizen-4c410968c1f6@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230516-kommode-weizen-4c410968c1f6@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, May 16, 2023 at 06:00:05PM +0200, Christian Brauner wrote: > Looking at this code reminds me that we'll need a block dev lookup > function that takes a diskseq argument so we can lookup a block device > and check it against the diskseq number we provided so we can detect > "media" changes (images on a loop device etc). Idea being to pass > diskseq numbers via fsconfig(). You can already do this by checking right after opening but before using it. In theory we could pass the seq down, and handle it further down, but I'm not sure this really solves anything. The main work here really is in the mount code.