From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35565C7EE2D for ; Mon, 5 Jun 2023 17:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234860AbjFERSv (ORCPT ); Mon, 5 Jun 2023 13:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234541AbjFERSs (ORCPT ); Mon, 5 Jun 2023 13:18:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152119E; Mon, 5 Jun 2023 10:18:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A406D622C3; Mon, 5 Jun 2023 17:18:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 013D0C433D2; Mon, 5 Jun 2023 17:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685985527; bh=zy4OYg5iAjuFpxS6eDlvpz+l89Wg9QaBuKy175VsrDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ttLD82w1O2tP4dTvksawB8IZOT/0vUz9IMYY0uq7p8wELeSxnFWBoTvu3Yn6qsyPw mnzAac5g1Il2wEst59f7KdsbQb4AILKVJpq6WFCc4G9cAXX5hqMx+HKLffPrcGwHtK xmeUTREm/G2RAD5GVXNLFJHJTqlZXlFIzP9cDQyA/yIzHXI6ezOXuFv1phqFVF/pVj rwr/fL3Xlk/2N3nI2eiUu+wHsV9WWeNAZdbpBm2X5wVlzMwRhk45wIq1USlWSRTAhy 182sIn7eAxs3Dp5IetfEIHQ/1uZn9O9f7TN/9c6USOW0fMnLT02Xq3zcKDqAl0FjxP VNbCf4U/A4Nvw== Date: Mon, 5 Jun 2023 10:18:46 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: Dave Chinner , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: DIO hangs in 6.4.0-rc2 Message-ID: <20230605171846.GM72241@frogsfrogsfrogs> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Jun 05, 2023 at 05:16:40PM +0100, Matthew Wilcox wrote: > On Wed, May 17, 2023 at 08:09:35AM +1000, Dave Chinner wrote: > > On Tue, May 16, 2023 at 01:28:00PM +0100, Matthew Wilcox wrote: > > > Plain 6.4.0-rc2 with a relatively minor change to the futex code that > > > I cannot believe was in any way responsible for this. > > > > > > kworkers blocked all over the place. Some on XFS_ILOCK_EXCL. Some on > > > xfs_buf_lock. One in xfs_btree_split() calling wait_for_completion. > > > > > > This was an overnight test run that is now dead, so I can't get any > > > more info from the locked up kernel. I have the vmlinux if some > > > decoding of offsets is useful. > > > > This is likely the same AGF try-lock bug that was discovered in this > > thread: > > > > https://lore.kernel.org/linux-xfs/202305090905.aff4e0e6-oliver.sang@intel.com/ > > > > The fact that the try-lock was ignored means that out of order AGF > > locking can be attempted, and the try-lock prevents deadlocks from > > occurring. > > > > Can you try the patch below - I was going to send it for review > > anyway this morning so it can't hurt to see if it also fixes this > > issue. > > I still have this patch in my tree and it's not in rc5. Was this > problem fixed some other way, or does it still need to land upstream? > I don't see any changes to XFS since May 11th's pull request. Seems to have landed in for-next last night? https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git/commit/?h=for-next&id=00dcd17cfa7f103f7d640ffd34645a2ddab96330 --D