[PATCH] xfs: Comment out unreachable code within xchk_fscounters()

[PATCH] xfs: Comment out unreachable code within xchk_fscounters()

[cem]

From: Carlos Maiolino <cem@kernel.org>

Comment the code out so kernel test robot stop complaining about it
every single test build.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
---
 fs/xfs/scrub/fscounters.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/xfs/scrub/fscounters.c b/fs/xfs/scrub/fscounters.c
index e382a35e98d88..b1148bea7fabc 100644
--- a/fs/xfs/scrub/fscounters.c
+++ b/fs/xfs/scrub/fscounters.c
@@ -452,6 +452,7 @@ xchk_fscounters(
 	 */
 	return 0;
 
+#if 0
 	/*
 	 * If ifree exceeds icount by more than the minimum variance then
 	 * something's probably wrong with the counters.
@@ -489,4 +490,5 @@ xchk_fscounters(
 		xchk_set_corrupt(sc);
 
 	return 0;
+#endif
 }
-- 
2.30.2

Re: [PATCH] xfs: Comment out unreachable code within xchk_fscounters()

[Carlos Maiolino]

On Tue, Jun 06, 2023 at 03:37:10PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Comment the code out so kernel test robot stop complaining about it
> every single test build.

Please, ignore this, as commenting out the unreachable code created another
warnings. I'll fix it and resend the patch. Sorry the noise.


> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Carlos Maiolino <cem@kernel.org>
> ---
>  fs/xfs/scrub/fscounters.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/scrub/fscounters.c b/fs/xfs/scrub/fscounters.c
> index e382a35e98d88..b1148bea7fabc 100644
> --- a/fs/xfs/scrub/fscounters.c
> +++ b/fs/xfs/scrub/fscounters.c
> @@ -452,6 +452,7 @@ xchk_fscounters(
>  	 */
>  	return 0;
> 
> +#if 0
>  	/*
>  	 * If ifree exceeds icount by more than the minimum variance then
>  	 * something's probably wrong with the counters.
> @@ -489,4 +490,5 @@ xchk_fscounters(
>  		xchk_set_corrupt(sc);
> 
>  	return 0;
> +#endif
>  }
> --
> 2.30.2
>