Re: [PATCH V2] xfs: Comment out unreachable code within xchk_fscounters()

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Jun 06, 2023 at 05:11:22PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Comment the code out so kernel test robot stop complaining about it
> every single test build.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Thank you,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/scrub/fscounters.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/xfs/scrub/fscounters.c b/fs/xfs/scrub/fscounters.c
> index e382a35e98d88..228efe0c99be8 100644
> --- a/fs/xfs/scrub/fscounters.c
> +++ b/fs/xfs/scrub/fscounters.c
> @@ -153,6 +153,7 @@ xchk_setup_fscounters(
>  	return xchk_trans_alloc(sc, 0);
>  }
>  
> +#if 0
>  /*
>   * Part 1: Collecting filesystem summary counts.  For each AG, we add its
>   * summary counts (total inodes, free inodes, free data blocks) to an incore
> @@ -349,6 +350,7 @@ xchk_fscount_count_frextents(
>  	return 0;
>  }
>  #endif /* CONFIG_XFS_RT */
> +#endif
>  
>  /*
>   * Part 2: Comparing filesystem summary counters.  All we have to do here is
> @@ -422,7 +424,10 @@ xchk_fscounters(
>  	struct xfs_mount	*mp = sc->mp;
>  	struct xchk_fscounters	*fsc = sc->buf;
>  	int64_t			icount, ifree, fdblocks, frextents;
> +
> +#if 0
>  	int			error;
> +#endif
>  
>  	/* Snapshot the percpu counters. */
>  	icount = percpu_counter_sum(&mp->m_icount);
> @@ -452,6 +457,7 @@ xchk_fscounters(
>  	 */
>  	return 0;
>  
> +#if 0
>  	/*
>  	 * If ifree exceeds icount by more than the minimum variance then
>  	 * something's probably wrong with the counters.
> @@ -489,4 +495,5 @@ xchk_fscounters(
>  		xchk_set_corrupt(sc);
>  
>  	return 0;
> +#endif
>  }
> -- 
> 2.30.2
>