From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07921C7EE29 for ; Wed, 7 Jun 2023 14:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241201AbjFGOyF (ORCPT ); Wed, 7 Jun 2023 10:54:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241204AbjFGOyC (ORCPT ); Wed, 7 Jun 2023 10:54:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ABE21FD6 for ; Wed, 7 Jun 2023 07:53:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A63264055 for ; Wed, 7 Jun 2023 14:53:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F29E7C43443; Wed, 7 Jun 2023 14:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686149631; bh=nTCXDta0QRjDabyrNK7eEGeEo1FT4gI+T9EM0zWIf1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JqENLhVwhQdl+/bvurAU8n+NGKaGTX75G8ULnBR9WKrLbTF42MjCMNkWijPr+QKaC K0hP1aLBtwDjvbznNpiwd5n2cqxbxqjBGH8LMVAUwx29g5KTk36BkHqMlKWN7gipwh pmhdnQIDrIBp/e58Ae5LZnC9/LSiJm7ro7wG2DqL3lewDamSbfF8VwJJc9crqq/SHL 7wNF+xiwRUug9ywIo0bA1QUu8kzND1BQiYAzwKcZyWC+vK9efPIj1K3QrqY3/bk5Yu CYGstmOKEWaGP8TQE/MQFkUt8Ra+8Yvet/DQKvWmo4trpNdiTQt8ookJfEnwy1TFn9 d/+w8NQgdlbVg== Date: Wed, 7 Jun 2023 07:53:50 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Carlos Maiolino , linux-xfs@vger.kernel.org Subject: Re: [PATCH V2] xfs: Comment out unreachable code within xchk_fscounters() Message-ID: <20230607145350.GS1325469@frogsfrogsfrogs> References: <20230606151122.853315-1-cem@kernel.org> <20230607073757.zwfhie3qbn7mox5i@andromeda> <20230607084804.vh3dz6qvgbkotjav@andromeda> <20230607142812.GR1325469@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jun 07, 2023 at 07:30:55AM -0700, Christoph Hellwig wrote: > On Wed, Jun 07, 2023 at 07:28:12AM -0700, Darrick J. Wong wrote: > > *Someone* please just review the fixes for fscounters.c that I put on > > the list two weeks ago. The first two patches of the patchset are > > sufficient to fix this problem. > > > > https://lore.kernel.org/linux-xfs/168506061483.3732954.5178462816967376906.stgit@frogsfrogsfrogs/ > > That sounds like a way better idea indeed. I'll get to it after my > meetings. FYI there's a parallel discussion about the same patch going on fsdevel: https://lore.kernel.org/linux-fsdevel/20230522234200.GC11598@frogsfrogsfrogs/ --D