Re: [PATCH 6/8] xfs: journal geometry is not properly bounds checked

Christoph Hellwig
2023-06-28T09:28:42Z

> + if (sbp->sb_logblocks > XFS_MAX_LOG_BLOCKS) {
> + xfs_notice(mp,
> + "Log size 0x%x blocks too large, maximum size is 0x%llx blocks",
> + sbp->sb_logblocks, XFS_MAX_LOG_BLOCKS);

Just a little nitpick, didn't we traditionally align the overly
long format strings with a single tab and not to the same line as
the xfs_notice/warn/etc?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>