From: Kees Cook <keescook@chromium.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: xfs WARNING on v6.5-rc1 kernel
Date: Tue, 11 Jul 2023 14:37:20 -0700 [thread overview]
Message-ID: <202307111435.1C23ECE259@keescook> (raw)
In-Reply-To: <20230710170243.GF11456@frogsfrogsfrogs>
On Mon, Jul 10, 2023 at 10:02:43AM -0700, Darrick J. Wong wrote:
> On Mon, Jul 10, 2023 at 12:29:29PM -0400, Jeff Layton wrote:
> > I hit this this morning while running generic/013 (fsstress), with a
> > kernel based on v6.5-rc1. The main changes on top of this are timestamp
> > related, so I doubt they're a factor here.
> >
> > Is this some of the flexarray hardening?
>
> Yes.
>
> https://lore.kernel.org/linux-xfs/ZI+3QXDHiohgv%2FPb@dread.disaster.area/
> https://lore.kernel.org/linux-xfs/bug-217522-201763-D34HpuP9xe@https.bugzilla.kernel.org%2F/
> https://lore.kernel.org/linux-xfs/Y9xiYmVLRIKdpJcC@work/
It looks like these just need struct tweaks to avoid using legacy array
definitions. It can be done without changes to the size of the structs,
etc.
I'll send a patch...
--
Kees Cook
prev parent reply other threads:[~2023-07-11 21:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 16:29 xfs WARNING on v6.5-rc1 kernel Jeff Layton
2023-07-10 17:02 ` Darrick J. Wong
2023-07-11 21:37 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307111435.1C23ECE259@keescook \
--to=keescook@chromium.org \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox