From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5BFEB64DC for ; Tue, 11 Jul 2023 21:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbjGKVhb (ORCPT ); Tue, 11 Jul 2023 17:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230472AbjGKVha (ORCPT ); Tue, 11 Jul 2023 17:37:30 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DC1E1733 for ; Tue, 11 Jul 2023 14:37:22 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-666ed230c81so5477150b3a.0 for ; Tue, 11 Jul 2023 14:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689111442; x=1691703442; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RKp/iJWUOzi9KMXmJKLevJSI+NVSsqJRkj/8g2JsU8E=; b=cu5+S530R/eq040xxEUPFXyShpV5poEU7JpztU9iDouEAMhHEha6D+VLWsTLjREscx H14PqMpBkBneS79SqcJ6ebnD+bjqC+dRgWJw4dWUEcc7MGNlb5l2NOAESlsgHjaz/x+8 MBys/t8lXi8vfZxpoR9aN14q9zVmOEdHxSNwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689111442; x=1691703442; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RKp/iJWUOzi9KMXmJKLevJSI+NVSsqJRkj/8g2JsU8E=; b=g/vJ2cf+47sUBgHQ7oGWPfyvhh7/j93d30hnJrzNyW/f9tw/C2yzM8JdUsm6+5BQSJ z1uc01ZWujXfIyM6t/gkOOpodJ8Mqy3PFOEGxnZsC33wHurxRvpFJdigAbDbNHO5Y2oA pTvD9jtXb97bo7efMU2WdxJjNLaDPWidX5APmcd2M4i1mOle52bkOI3Dsmzvhln17v25 D1V8fYN13UJHFcVybtMM76JSaYp8h3zALE+dgIMztIuXnhdcGQ+95pRiyrM3nwaailmg JrrikVmc2L/5+EKXiHTdUOO8mWQV8lHFUrfYsRZgV7Z26Bqx9WArbKn4YGB+C6ywCMVR u5oA== X-Gm-Message-State: ABy/qLaJUujJquUjdVqNP2jMQoRS2+ShUCp9ls8HWsDrBRdJRpAg1aAf QNQEUgSURv7w9XSkDqarql7qnV9UJ09a87CVKoQ= X-Google-Smtp-Source: APBJJlFHw1J61BjsIKrEI1HNcYSK6FCsFONXV06oHSAjIGr/JI8k4AmvLLm/LB4JHwss+ywUCREizA== X-Received: by 2002:a17:902:b711:b0:1b7:fd82:973c with SMTP id d17-20020a170902b71100b001b7fd82973cmr16407025pls.39.1689111441812; Tue, 11 Jul 2023 14:37:21 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i10-20020a170902eb4a00b001b8b73da7b1sm2382979pli.227.2023.07.11.14.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 14:37:21 -0700 (PDT) Date: Tue, 11 Jul 2023 14:37:20 -0700 From: Kees Cook To: "Darrick J. Wong" Cc: Jeff Layton , linux-xfs , linux-kernel Subject: Re: xfs WARNING on v6.5-rc1 kernel Message-ID: <202307111435.1C23ECE259@keescook> References: <17881cf776b2c19dcd5a6d628fdfb54dae0eb4f8.camel@kernel.org> <20230710170243.GF11456@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710170243.GF11456@frogsfrogsfrogs> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Jul 10, 2023 at 10:02:43AM -0700, Darrick J. Wong wrote: > On Mon, Jul 10, 2023 at 12:29:29PM -0400, Jeff Layton wrote: > > I hit this this morning while running generic/013 (fsstress), with a > > kernel based on v6.5-rc1. The main changes on top of this are timestamp > > related, so I doubt they're a factor here. > > > > Is this some of the flexarray hardening? > > Yes. > > https://lore.kernel.org/linux-xfs/ZI+3QXDHiohgv%2FPb@dread.disaster.area/ > https://lore.kernel.org/linux-xfs/bug-217522-201763-D34HpuP9xe@https.bugzilla.kernel.org%2F/ > https://lore.kernel.org/linux-xfs/Y9xiYmVLRIKdpJcC@work/ It looks like these just need struct tweaks to avoid using legacy array definitions. It can be done without changes to the size of the structs, etc. I'll send a patch... -- Kees Cook