From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8A2C0015E for ; Thu, 13 Jul 2023 04:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233666AbjGMEqD (ORCPT ); Thu, 13 Jul 2023 00:46:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233716AbjGMEqB (ORCPT ); Thu, 13 Jul 2023 00:46:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A225210A; Wed, 12 Jul 2023 21:46:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9471F61A21; Thu, 13 Jul 2023 04:45:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4A7CC433C8; Thu, 13 Jul 2023 04:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689223559; bh=CVdaU3qbMuVNwFTXmDG9OBUnultd43nLJ7Ze2Guc+xo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ina4QbF8y8iptModPQTMHaixEG0sLH7vCDGVO2RhvdlG+8YLxGVj1JZVAt49l7h4M TvSri7XtDKiSyCSQt4+HLHYYnX1OSEZvR6aqh2sLn8ADAPR4TCYjR5xh/qhR8RKpoY C5DKKnFa7gp09v2wUwJEwppOV+k7uQo7VHV5ZNmV1NCaDFoU/S2wt4PC/kL5gLWTVA lY/19ZQ74RSjtFive+jPgRBJ8rGRwKTfR0/QkullftSs3RTuqkC4s179V/PXODrnT8 H3G2oFWzHHzvyyCbd48HtKyj1/hz8CgrBf1KDzNEpK3OF/SJODrv+rUD5DmHqCuzJ1 xalnb1nwDZSQQ== Date: Wed, 12 Jul 2023 21:45:58 -0700 From: "Darrick J. Wong" To: "Matthew Wilcox (Oracle)" , "Ritesh Harjani (IBM)" Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Wang Yugui , Dave Chinner , Christoph Hellwig , Kent Overstreet , Christoph Hellwig Subject: Re: [PATCH v4 5/9] iomap: Remove unnecessary test from iomap_release_folio() Message-ID: <20230713044558.GJ108251@frogsfrogsfrogs> References: <20230710130253.3484695-1-willy@infradead.org> <20230710130253.3484695-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710130253.3484695-6-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org [add ritesh] On Mon, Jul 10, 2023 at 02:02:49PM +0100, Matthew Wilcox (Oracle) wrote: > The check for the folio being under writeback is unnecessary; the caller > has checked this and the folio is locked, so the folio cannot be under > writeback at this point. > > The comment is somewhat misleading in that it talks about one specific > situation in which we can see a dirty folio. There are others, so change > the comment to explain why we can't release the iomap_page. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- > fs/iomap/buffered-io.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 1cb905140528..7aa3009f907f 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -483,12 +483,11 @@ bool iomap_release_folio(struct folio *folio, gfp_t gfp_flags) > folio_size(folio)); > > /* > - * mm accommodates an old ext3 case where clean folios might > - * not have had the dirty bit cleared. Thus, it can send actual > - * dirty folios to ->release_folio() via shrink_active_list(); > - * skip those here. > + * If the folio is dirty, we refuse to release our metadata because > + * it may be partially dirty. Once we track per-block dirty state, > + * we can release the metadata if every block is dirty. Ritesh: I'm assuming that implementing this will be part of your v12 series? Reviewed-by: Darrick J. Wong --D > */ > - if (folio_test_dirty(folio) || folio_test_writeback(folio)) > + if (folio_test_dirty(folio)) > return false; > iomap_page_release(folio); > return true; > -- > 2.39.2 >