From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC5BC04A6A for ; Fri, 14 Jul 2023 14:16:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235860AbjGNOQh (ORCPT ); Fri, 14 Jul 2023 10:16:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235732AbjGNOQg (ORCPT ); Fri, 14 Jul 2023 10:16:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79CFE30C4 for ; Fri, 14 Jul 2023 07:16:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14F1961D2F for ; Fri, 14 Jul 2023 14:16:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB2CCC433B8; Fri, 14 Jul 2023 14:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689344194; bh=eKHVv/pRuBbmOTii2neJQC31RoLF8VLfexvjUMuiKnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mnuEc2uVc7shrCia2LIml8uwW1Add4Ue/iHQT6Q9PMtw2sykVBvBoNSVsf3j1zfB3 Vrz0ARe9B20U+g5E4L1LZP4hMd2klXRPUkSmOBR9F1e8F4eZVhTw4iw05SsdJZ/kW9 G9vXbWYSnyxAKEB1y9Vcs8oW4JRtXEauK7ccP8LUpFmtn5zkOv0yT8snJpSXmLkma/ app+G6BgXqMKORAk4kXl/8Yeg2arNc+HVX+OrcHCf9jbfNrK/jwA+8FA0FwjCzTlDf zLJWM56S1Ft/UHYt6Nk+MrE2ko9K243CKfW4sjxI0jFA+4EDzEX53FmhIurmnC7zxs lV+Mf1+w8uHYg== Date: Fri, 14 Jul 2023 07:16:32 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Anthony Iliopoulos , linux-xfs@vger.kernel.org Subject: Re: [PATCH v5 5/8] xfs: XFS_ICHGTIME_CREATE is unused Message-ID: <20230714141632.GU108251@frogsfrogsfrogs> References: <20230713-mgctime-v5-0-9eb795d2ae37@kernel.org> <20230713-mgctime-v5-5-9eb795d2ae37@kernel.org> <2b782aa87e50d6ee9195a9725fef2d56d52d8afe.camel@kernel.org> <20230714063502.GS108251@frogsfrogsfrogs> <6a2e25d21dde5e376af85ed5b691a0ddbb9cd478.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a2e25d21dde5e376af85ed5b691a0ddbb9cd478.camel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Jul 14, 2023 at 06:53:45AM -0400, Jeff Layton wrote: > On Thu, 2023-07-13 at 23:35 -0700, Darrick J. Wong wrote: > > On Thu, Jul 13, 2023 at 08:15:21PM -0400, Jeff Layton wrote: > > > On Fri, 2023-07-14 at 01:53 +0200, Anthony Iliopoulos wrote: > > > > On Thu, Jul 13, 2023 at 07:00:54PM -0400, Jeff Layton wrote: > > > > > Nothing ever sets this flag, which makes sense since the create time is > > > > > set at inode instantiation and is never changed. Remove it and the > > > > > handling of it in xfs_trans_ichgtime. > > > > > > > > It is currently used by xfs_repair during recreating the root inode and > > > > the internal realtime inodes when needed (libxfs is exported to xfsprogs > > > > so there are userspace consumers of this code). > > > > > > > > > > Ahh thanks. I didn't think to look at userland for this. We can drop > > > this patch, and I'll respin #6. > > > > > > Looking briefly at xfsprogs, it looks like XFS_ICHGTIME_CREATE is never > > > set without also setting XFS_ICHGTIME_CHG. Is that safe assumption? > > > > There are four timestamps in an xfs inode and an ICHGTIME flag for each: > > MOD is mtime, CHG is ctime, CREATE is crtime/btime, and ACCESS is atime. > > I'd rather leave it that way than tie flags together. > > > > > > I wasn't suggesting to tie any flags together. I just don't see any > scenario where it's OK to call xfs_trans_ichgtime() without > XFS_ICHGTIME_CHG set. It has to change if either of the other times > change. Oh! That's correct, I don't know of any place where the [bam]time get updated without also bumping ctime. --D > > > > > > > > Signed-off-by: Jeff Layton > > > > > --- > > > > > fs/xfs/libxfs/xfs_shared.h | 2 -- > > > > > fs/xfs/libxfs/xfs_trans_inode.c | 2 -- > > > > > 2 files changed, 4 deletions(-) > > > > > > > > > > diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h > > > > > index c4381388c0c1..8989fff21723 100644 > > > > > --- a/fs/xfs/libxfs/xfs_shared.h > > > > > +++ b/fs/xfs/libxfs/xfs_shared.h > > > > > @@ -126,8 +126,6 @@ void xfs_log_get_max_trans_res(struct xfs_mount *mp, > > > > > */ > > > > > #define XFS_ICHGTIME_MOD 0x1 /* data fork modification timestamp */ > > > > > #define XFS_ICHGTIME_CHG 0x2 /* inode field change timestamp */ > > > > > -#define XFS_ICHGTIME_CREATE 0x4 /* inode create timestamp */ > > > > > - > > > > > > > > > > /* > > > > > * Symlink decoding/encoding functions > > > > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > > > > > index 6b2296ff248a..0c9df8df6d4a 100644 > > > > > --- a/fs/xfs/libxfs/xfs_trans_inode.c > > > > > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > > > > > @@ -68,8 +68,6 @@ xfs_trans_ichgtime( > > > > > inode->i_mtime = tv; > > > > > if (flags & XFS_ICHGTIME_CHG) > > > > > inode_set_ctime_to_ts(inode, tv); > > > > > - if (flags & XFS_ICHGTIME_CREATE) > > > > > - ip->i_crtime = tv; > > > > > } > > > > > > > > > > /* > > > > > > > > > > -- > > > > > 2.41.0 > > > > > > > > > > > > > > > > > > > -- > > > Jeff Layton > > -- > Jeff Layton