From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org, hch@lst.de,
keescook@chromium.org, david@fromorbit.com
Subject: Re: [PATCH 1/3] xfs: convert flex-array declarations in struct xfs_attrlist*
Date: Fri, 14 Jul 2023 16:46:38 +0200 [thread overview]
Message-ID: <20230714144638.GA3628@lst.de> (raw)
In-Reply-To: <168934591095.3368057.15849162788748534581.stgit@frogsfrogsfrogs>
The change itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But as mentioned in the last thread leaving these out in the UAPI
is a bit dangerous, and at the same time they really shouldn't
be in the uapi. Do you want me to send an incremental patch for
that?
next prev parent reply other threads:[~2023-07-14 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 14:45 [PATCHSET 0/3] xfsprogs: ubsan fixes for 6.5-rc2 Darrick J. Wong
2023-07-14 14:45 ` [PATCH 1/3] xfs: convert flex-array declarations in struct xfs_attrlist* Darrick J. Wong
2023-07-14 14:46 ` Christoph Hellwig [this message]
2023-07-14 14:54 ` Darrick J. Wong
2023-07-14 14:56 ` Christoph Hellwig
2023-07-14 14:45 ` [PATCH 2/3] xfs: convert flex-array declarations in xfs attr leaf blocks Darrick J. Wong
2023-07-14 14:54 ` Christoph Hellwig
2023-07-14 14:45 ` [PATCH 3/3] xfs: convert flex-array declarations in xfs attr shortform objects Darrick J. Wong
2023-07-14 14:50 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-07-14 14:42 [PATCHSET 0/3] xfs: ubsan fixes for 6.5-rc2 Darrick J. Wong
2023-07-14 14:42 ` [PATCH 1/3] xfs: convert flex-array declarations in struct xfs_attrlist* Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714144638.GA3628@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox