public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Bill O'Donnell <bodonnel@redhat.com>
Cc: linux-xfs@vger.kernel.org, cem@kernel.org
Subject: Re: [PATCH] mkfs.xfs.8: correction on mkfs.xfs manpage since reflink and dax are compatible
Date: Fri, 28 Jul 2023 15:33:09 -0700	[thread overview]
Message-ID: <20230728223309.GH11352@frogsfrogsfrogs> (raw)
In-Reply-To: <20230728222017.178599-1-bodonnel@redhat.com>

On Fri, Jul 28, 2023 at 05:20:17PM -0500, Bill O'Donnell wrote:
> Merged early in 2023: Commit 480017957d638 xfs: remove restrictions for fsdax
> and reflink. There needs to be a corresponding change to the mkfs.xfs manpage
> to remove the incompatiblity statement.
> 
> Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
> ---
>  man/man8/mkfs.xfs.8.in | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
> index ce6f1e2d..08bb92f6 100644
> --- a/man/man8/mkfs.xfs.8.in
> +++ b/man/man8/mkfs.xfs.8.in
> @@ -323,13 +323,6 @@ option set. When the option
>  .B \-m crc=0
>  is used, the reference count btree feature is not supported and reflink is
>  disabled.
> -.IP
> -Note: the filesystem DAX mount option (
> -.B \-o dax
> -) is incompatible with
> -reflink-enabled XFS filesystems.  To use filesystem DAX with XFS, specify the
> -.B \-m reflink=0
> -option to mkfs.xfs to disable the reflink feature.

D'oh, we forgot to remove that.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  .RE
>  .PP
>  .PD 0
> -- 
> 2.41.0
> 

  reply	other threads:[~2023-07-28 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <66z3bx95e2xL_ZIVsmJU4cLb5z2V8aW7EpQ6kArDfJ2ej7brNwRcbuXvcbLP2pFWdXyFSPBFTRWG-U62SMRU7A==@protonmail.internalid>
2023-07-28 22:20 ` [PATCH] mkfs.xfs.8: correction on mkfs.xfs manpage since reflink and dax are compatible Bill O'Donnell
2023-07-28 22:33   ` Darrick J. Wong [this message]
2023-08-02  8:52   ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728223309.GH11352@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=bodonnel@redhat.com \
    --cc=cem@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox