public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH] xfs: skip fragmentation tests when alwayscow mode is enabled, part 2
Date: Fri, 4 Aug 2023 14:34:19 -0700	[thread overview]
Message-ID: <20230804213419.GO11340@frogsfrogsfrogs> (raw)

From: Darrick J. Wong <djwong@kernel.org>

If the always_cow debugging flag is enabled, all file writes turn into
copy writes.  This dramatically ramps up fragmentation in the filesystem
(intentionally!) so there's no point in complaining about fragmentation.

I missed these two in the original commit because readahead for md5sum
would create large folios at the start of the file.  This resulted in
the fdatatasync after the random writes issuing writeback for the whole
large folio, which reduced file fragmentation to the point where this
test started passing.

With Ritesh's patchset implementing sub-folio dirty tracking, this test
goes back to failing due to high fragmentation (as it did before large
folios) so we need to mask these off too.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/180 |    1 +
 tests/xfs/208 |    1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/xfs/180 b/tests/xfs/180
index cfea2020ce..d2fac03a9e 100755
--- a/tests/xfs/180
+++ b/tests/xfs/180
@@ -23,6 +23,7 @@ _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fiemap"
 _require_xfs_io_command "cowextsize"
+_require_no_xfs_always_cow
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
diff --git a/tests/xfs/208 b/tests/xfs/208
index 9a71b74f6f..1e7734b822 100755
--- a/tests/xfs/208
+++ b/tests/xfs/208
@@ -26,6 +26,7 @@ _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fiemap"
 _require_xfs_io_command "cowextsize"
+_require_no_xfs_always_cow
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1

             reply	other threads:[~2023-08-04 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 21:34 Darrick J. Wong [this message]
2023-08-05 13:51 ` [PATCH] xfs: skip fragmentation tests when alwayscow mode is enabled, part 2 Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230804213419.GO11340@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox