From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F52EC001B0 for ; Wed, 9 Aug 2023 15:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233257AbjHIP3Z (ORCPT ); Wed, 9 Aug 2023 11:29:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231611AbjHIP3Y (ORCPT ); Wed, 9 Aug 2023 11:29:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21D28E7F; Wed, 9 Aug 2023 08:29:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 80B3163DFD; Wed, 9 Aug 2023 15:29:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D215BC433C8; Wed, 9 Aug 2023 15:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691594962; bh=cFJwIe738mm8LLl2B6Xbs3kFw4rHn692G5TR86ypGJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XD+cZG+1UUrkGTM7zZOfsHjD1Gbto/HRg+3ZkinJGlo/rZXicwWnDqj9KR2VDGoGg /fk5uSVaNjzGJ6mCs1kUKLG4lpEKQIh3NZ7LrUefwNwcnCQaWL4GgVOy9VJZrudz23 qWP9pK5IERNei1DDdfZYDlfHZ7/Juia+Gyrdko//TcW5D84pK3GBLJmTU5ghwOgcz+ wdtvFRJ3b1QZ3xNMoYc3r9HynXNiMu6vMJ4kIl9OyN6sXxXxL9I1nU8jjiJXhVLqdE EY1mdhSYoPCyWP/yfME20Ln4rFHa5BDbXVr07CbGtmoO3XbuH/sVk3PapGUMroNsx3 dG2GRqVEDarrQ== Date: Wed, 9 Aug 2023 08:29:22 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Al Viro , Christian Brauner , Namjae Jeon , Sungjong Seo , Theodore Ts'o , Andreas Dilger , Konstantin Komarov , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org Subject: Re: [PATCH 02/13] xfs: remove a superflous s_fs_info NULL check in xfs_fs_put_super Message-ID: <20230809152922.GQ11352@frogsfrogsfrogs> References: <20230808161600.1099516-1-hch@lst.de> <20230808161600.1099516-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808161600.1099516-3-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Aug 08, 2023 at 09:15:49AM -0700, Christoph Hellwig wrote: > ->put_super is only called when sb->s_root is set, and thus when > fill_super succeeds. Thus drop the NULL check that can't happen in > xfs_fs_put_super. > > Signed-off-by: Christoph Hellwig Ahahaha, here's the /rest/ of the patchset. I wondered if vger was busted yesterday. Carrying on... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_super.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 0a294659c18972..128f4a2924d49c 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1132,10 +1132,6 @@ xfs_fs_put_super( > { > struct xfs_mount *mp = XFS_M(sb); > > - /* if ->fill_super failed, we have no mount to tear down */ > - if (!sb->s_fs_info) > - return; > - > xfs_notice(mp, "Unmounting Filesystem %pU", &mp->m_sb.sb_uuid); > xfs_filestream_unmount(mp); > xfs_unmountfs(mp); > -- > 2.39.2 >