Re: [PATCH 3/3] xfs: remove cpu hotplug hooks

Dave Chinner
2023-08-25T00:16:00Z

On Thu, Aug 24, 2023 at 04:21:31PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> There are no users of the cpu hotplug hooks in xfs now, so remove the
> infrastructure.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_super.c | 50 +-------------------------------------------
> include/linux/cpuhotplug.h | 1 -
> 2 files changed, 1 insertion(+), 50 deletions(-)

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

>
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 6a4f8b2f6159..1403aace4fe3 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -2301,47 +2301,6 @@ xfs_destroy_workqueues(void)
> destroy_workqueue(xfs_alloc_wq);
> }
>
> -#ifdef CONFIG_HOTPLUG_CPU
> -static int
> -xfs_cpu_dead(
> - unsigned int cpu)
> -{
> - struct xfs_mount *mp, *n;
> -
> - spin_lock(&xfs_mount_list_lock);
> - list_for_each_entry_safe(mp, n, &xfs_mount_list, m_mount_list) {
> - spin_unlock(&xfs_mount_list_lock);
> - spin_lock(&xfs_mount_list_lock);
> - }
> - spin_unlock(&xfs_mount_list_lock);
> - return 0;
> -}

You also can kill the xfs_mount_list and xfs_mount_list_lock now,
right? That can be done in a separate patch, though.

-Dave.
--
Dave Chinner
david@fromorbit.com