From: "Darrick J. Wong" <djwong@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Chandan Babu R <chandan.babu@oracle.com>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS
Date: Fri, 25 Aug 2023 08:15:01 -0700 [thread overview]
Message-ID: <20230825151501.GJ17912@frogsfrogsfrogs> (raw)
In-Reply-To: <20230825120513.29235-1-lukas.bulwahn@gmail.com>
On Fri, Aug 25, 2023 at 02:05:13PM +0200, Lukas Bulwahn wrote:
> Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing
> config FS_DEBUG. It is probably intended to select the existing config
> XFS_DEBUG.
>
> Fix the select in config XFS_ONLINE_SCRUB_STATS.
>
> Fixes: d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Oops.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> ---
> Darrick, please pick this quick 'typo' fix.
^^^^ isn't the maintainer anymore. ;)
--D
> v2: removed a stupid last-minute insert on my Signed-off-by line.
>
> fs/xfs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index c9d653168ad0..ed0bc8cbc703 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
> bool "XFS online metadata check usage data collection"
> default y
> depends on XFS_ONLINE_SCRUB
> - select FS_DEBUG
> + select XFS_DEBUG
> help
> If you say Y here, the kernel will gather usage data about
> the online metadata check subsystem. This includes the number
> --
> 2.17.1
>
prev parent reply other threads:[~2023-08-25 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 12:05 [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS Lukas Bulwahn
2023-08-25 15:15 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825151501.GJ17912@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox