* Re: [PATCH] Documentation: xfs: Remove repeated word in comments [not found] <20230918071905.296081-1-hanchunchao@inspur.com> @ 2023-09-19 21:03 ` Dave Chinner 2023-09-19 21:15 ` Matthew Wilcox 2023-09-19 22:10 ` Darrick J. Wong 0 siblings, 2 replies; 6+ messages in thread From: Dave Chinner @ 2023-09-19 21:03 UTC (permalink / raw) To: Charles Han Cc: corbet, djwong, allison.henderson, bhelgaas, linux-doc, linux-kernel, linux-xfs [cc linux-xfs@vger.kernel.org] Hi Charles, For future reference, can you CC the XFS list on XFS documentation changes please? That's much preferable to sending patches to random developers and hoping they notice it.... On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote: > Remove the repeated word "the" in comments. > > Signed-off-by: Charles Han <hanchunchao@inspur.com> > --- > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst > index 1625d1131093..a0678101a7d0 100644 > --- a/Documentation/filesystems/xfs-online-fsck-design.rst > +++ b/Documentation/filesystems/xfs-online-fsck-design.rst > @@ -1585,7 +1585,7 @@ The transaction sequence looks like this: > 2. The second transaction contains a physical update to the free space btrees > of AG 3 to release the former BMBT block and a second physical update to the > free space btrees of AG 7 to release the unmapped file space. > - Observe that the the physical updates are resequenced in the correct order > + Observe that the physical updates are resequenced in the correct order Change looks fine, though. Reviewed: Dave Chinner <dchinner@redhat.com> -- Dave Chinner dchinner@redhat.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: xfs: Remove repeated word in comments 2023-09-19 21:03 ` [PATCH] Documentation: xfs: Remove repeated word in comments Dave Chinner @ 2023-09-19 21:15 ` Matthew Wilcox 2023-09-19 21:55 ` Dave Chinner ` (2 more replies) 2023-09-19 22:10 ` Darrick J. Wong 1 sibling, 3 replies; 6+ messages in thread From: Matthew Wilcox @ 2023-09-19 21:15 UTC (permalink / raw) To: Dave Chinner Cc: Charles Han, corbet, djwong, allison.henderson, bhelgaas, linux-doc, linux-kernel, linux-xfs [-- Attachment #1: Type: text/plain, Size: 870 bytes --] On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote: > [cc linux-xfs@vger.kernel.org] > > Hi Charles, > > For future reference, can you CC the XFS list on XFS documentation > changes please? That's much preferable to sending patches to random > developers and hoping they notice it.... > > On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote: > > Remove the repeated word "the" in comments. > > > > Signed-off-by: Charles Han <hanchunchao@inspur.com> > > --- > > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst To be fair, this new file isn't listed in MAINTAINERS, so scripts/get_maintainer.pl doesn't know about it. May I suggest the attached patch? [-- Attachment #2: 0001-XFS-Update-MAINTAINERS-to-catch-all-XFS-documentatio.patch --] [-- Type: text/plain, Size: 1064 bytes --] From e0eb2f0d1425e6a5dae23c983eb793afa5d040c1 Mon Sep 17 00:00:00 2001 From: "Matthew Wilcox (Oracle)" <willy@infradead.org> Date: Tue, 19 Sep 2023 17:12:45 -0400 Subject: [PATCH] XFS: Update MAINTAINERS to catch all XFS documentation Assumes that all XFS documentation will be prefixed with xfs-, which seems like a good policy anyway. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index bf0f54c24f81..3554195022ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23640,8 +23640,7 @@ T: git git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git P: Documentation/filesystems/xfs-maintainer-entry-profile.rst F: Documentation/ABI/testing/sysfs-fs-xfs F: Documentation/admin-guide/xfs.rst -F: Documentation/filesystems/xfs-delayed-logging-design.rst -F: Documentation/filesystems/xfs-self-describing-metadata.rst +F: Documentation/filesystems/xfs-* F: fs/xfs/ F: include/uapi/linux/dqblk_xfs.h F: include/uapi/linux/fsmap.h -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: xfs: Remove repeated word in comments 2023-09-19 21:15 ` Matthew Wilcox @ 2023-09-19 21:55 ` Dave Chinner 2023-09-19 22:09 ` Darrick J. Wong 2023-09-27 12:27 ` Chandan Babu R 2 siblings, 0 replies; 6+ messages in thread From: Dave Chinner @ 2023-09-19 21:55 UTC (permalink / raw) To: Matthew Wilcox Cc: Dave Chinner, Charles Han, corbet, djwong, allison.henderson, bhelgaas, linux-doc, linux-kernel, linux-xfs On Tue, Sep 19, 2023 at 10:15:21PM +0100, Matthew Wilcox wrote: > On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote: > > [cc linux-xfs@vger.kernel.org] > > > > Hi Charles, > > > > For future reference, can you CC the XFS list on XFS documentation > > changes please? That's much preferable to sending patches to random > > developers and hoping they notice it.... > > > > On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote: > > > Remove the repeated word "the" in comments. > > > > > > Signed-off-by: Charles Han <hanchunchao@inspur.com> > > > --- > > > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst > > To be fair, this new file isn't listed in MAINTAINERS, so > scripts/get_maintainer.pl doesn't know about it. May I > suggest the attached patch? > From e0eb2f0d1425e6a5dae23c983eb793afa5d040c1 Mon Sep 17 00:00:00 2001 > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Date: Tue, 19 Sep 2023 17:12:45 -0400 > Subject: [PATCH] XFS: Update MAINTAINERS to catch all XFS documentation > > Assumes that all XFS documentation will be prefixed with xfs-, which > seems like a good policy anyway. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bf0f54c24f81..3554195022ee 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23640,8 +23640,7 @@ T: git git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git > P: Documentation/filesystems/xfs-maintainer-entry-profile.rst > F: Documentation/ABI/testing/sysfs-fs-xfs > F: Documentation/admin-guide/xfs.rst > -F: Documentation/filesystems/xfs-delayed-logging-design.rst > -F: Documentation/filesystems/xfs-self-describing-metadata.rst > +F: Documentation/filesystems/xfs-* > F: fs/xfs/ > F: include/uapi/linux/dqblk_xfs.h > F: include/uapi/linux/fsmap.h Looks fine to me. Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: xfs: Remove repeated word in comments 2023-09-19 21:15 ` Matthew Wilcox 2023-09-19 21:55 ` Dave Chinner @ 2023-09-19 22:09 ` Darrick J. Wong 2023-09-27 12:27 ` Chandan Babu R 2 siblings, 0 replies; 6+ messages in thread From: Darrick J. Wong @ 2023-09-19 22:09 UTC (permalink / raw) To: Matthew Wilcox Cc: Dave Chinner, Charles Han, corbet, allison.henderson, bhelgaas, linux-doc, linux-kernel, linux-xfs On Tue, Sep 19, 2023 at 10:15:21PM +0100, Matthew Wilcox wrote: > On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote: > > [cc linux-xfs@vger.kernel.org] > > > > Hi Charles, > > > > For future reference, can you CC the XFS list on XFS documentation > > changes please? That's much preferable to sending patches to random > > developers and hoping they notice it.... > > > > On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote: > > > Remove the repeated word "the" in comments. > > > > > > Signed-off-by: Charles Han <hanchunchao@inspur.com> > > > --- > > > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst > > To be fair, this new file isn't listed in MAINTAINERS, so > scripts/get_maintainer.pl doesn't know about it. May I > suggest the attached patch? > From e0eb2f0d1425e6a5dae23c983eb793afa5d040c1 Mon Sep 17 00:00:00 2001 > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Date: Tue, 19 Sep 2023 17:12:45 -0400 > Subject: [PATCH] XFS: Update MAINTAINERS to catch all XFS documentation > > Assumes that all XFS documentation will be prefixed with xfs-, which > seems like a good policy anyway. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> LGTM, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bf0f54c24f81..3554195022ee 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23640,8 +23640,7 @@ T: git git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git > P: Documentation/filesystems/xfs-maintainer-entry-profile.rst > F: Documentation/ABI/testing/sysfs-fs-xfs > F: Documentation/admin-guide/xfs.rst > -F: Documentation/filesystems/xfs-delayed-logging-design.rst > -F: Documentation/filesystems/xfs-self-describing-metadata.rst > +F: Documentation/filesystems/xfs-* > F: fs/xfs/ > F: include/uapi/linux/dqblk_xfs.h > F: include/uapi/linux/fsmap.h > -- > 2.40.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: xfs: Remove repeated word in comments 2023-09-19 21:15 ` Matthew Wilcox 2023-09-19 21:55 ` Dave Chinner 2023-09-19 22:09 ` Darrick J. Wong @ 2023-09-27 12:27 ` Chandan Babu R 2 siblings, 0 replies; 6+ messages in thread From: Chandan Babu R @ 2023-09-27 12:27 UTC (permalink / raw) To: corbet Cc: Dave Chinner, Charles Han, djwong, allison.henderson, bhelgaas, linux-doc, linux-kernel, linux-xfs, Matthew Wilcox On Tue, Sep 19, 2023 at 10:15:21 PM +0100, Matthew Wilcox wrote: > On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote: >> [cc linux-xfs@vger.kernel.org] >> >> Hi Charles, >> >> For future reference, can you CC the XFS list on XFS documentation >> changes please? That's much preferable to sending patches to random >> developers and hoping they notice it.... >> >> On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote: >> > Remove the repeated word "the" in comments. >> > >> > Signed-off-by: Charles Han <hanchunchao@inspur.com> >> > --- >> > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst > > To be fair, this new file isn't listed in MAINTAINERS, so > scripts/get_maintainer.pl doesn't know about it. May I > suggest the attached patch? > > [2. text/plain; 0001-XFS-Update-MAINTAINERS-to-catch-all-XFS-documentatio.patch]... Hi Jonathan, I am planning to apply these two patches to xfs-linux's for-next branch and later send them to Linus. Please let me know if you have any objections. -- Chandan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: xfs: Remove repeated word in comments 2023-09-19 21:03 ` [PATCH] Documentation: xfs: Remove repeated word in comments Dave Chinner 2023-09-19 21:15 ` Matthew Wilcox @ 2023-09-19 22:10 ` Darrick J. Wong 1 sibling, 0 replies; 6+ messages in thread From: Darrick J. Wong @ 2023-09-19 22:10 UTC (permalink / raw) To: Dave Chinner Cc: Charles Han, corbet, allison.henderson, bhelgaas, linux-doc, linux-kernel, linux-xfs On Wed, Sep 20, 2023 at 07:03:36AM +1000, Dave Chinner wrote: > [cc linux-xfs@vger.kernel.org] > > Hi Charles, > > For future reference, can you CC the XFS list on XFS documentation > changes please? That's much preferable to sending patches to random > developers and hoping they notice it.... > > On Mon, Sep 18, 2023 at 03:19:05PM +0800, Charles Han wrote: > > Remove the repeated word "the" in comments. > > > > Signed-off-by: Charles Han <hanchunchao@inspur.com> Yup. Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > > --- > > Documentation/filesystems/xfs-online-fsck-design.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/filesystems/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs-online-fsck-design.rst > > index 1625d1131093..a0678101a7d0 100644 > > --- a/Documentation/filesystems/xfs-online-fsck-design.rst > > +++ b/Documentation/filesystems/xfs-online-fsck-design.rst > > @@ -1585,7 +1585,7 @@ The transaction sequence looks like this: > > 2. The second transaction contains a physical update to the free space btrees > > of AG 3 to release the former BMBT block and a second physical update to the > > free space btrees of AG 7 to release the unmapped file space. > > - Observe that the the physical updates are resequenced in the correct order > > + Observe that the physical updates are resequenced in the correct order > > Change looks fine, though. > > Reviewed: Dave Chinner <dchinner@redhat.com> > > -- > Dave Chinner > dchinner@redhat.com > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-27 12:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230918071905.296081-1-hanchunchao@inspur.com>
2023-09-19 21:03 ` [PATCH] Documentation: xfs: Remove repeated word in comments Dave Chinner
2023-09-19 21:15 ` Matthew Wilcox
2023-09-19 21:55 ` Dave Chinner
2023-09-19 22:09 ` Darrick J. Wong
2023-09-27 12:27 ` Chandan Babu R
2023-09-19 22:10 ` Darrick J. Wong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).