linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzesimir Nowak <qdlacz@gmail.com>
To: linux-xfs@vger.kernel.org
Cc: Krzesimir Nowak <knowak@microsoft.com>
Subject: [PATCH 1/1] libfrog: Fix cross-compilation issue with randbytes
Date: Tue, 26 Sep 2023 09:14:32 +0200	[thread overview]
Message-ID: <20230926071432.51866-2-knowak@microsoft.com> (raw)
In-Reply-To: <20230926071432.51866-1-knowak@microsoft.com>

randbytes.c was mostly split off from crc32.c and, like crc32.c, is
used for selftests, which are run on the build host. As such it should
not include platform_defs.h which in turn includes urcu.h from
userspace-rcu library, because the build host might not have the
library installed.

Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
---
 libfrog/randbytes.c | 1 -
 libfrog/randbytes.h | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/libfrog/randbytes.c b/libfrog/randbytes.c
index f22da0d3..2023b601 100644
--- a/libfrog/randbytes.c
+++ b/libfrog/randbytes.c
@@ -6,7 +6,6 @@
  *
  * This is the buffer of random bytes used for self tests.
  */
-#include "platform_defs.h"
 #include "libfrog/randbytes.h"
 
 /* 4096 random bytes */
diff --git a/libfrog/randbytes.h b/libfrog/randbytes.h
index 00fd7c4c..fddea9c7 100644
--- a/libfrog/randbytes.h
+++ b/libfrog/randbytes.h
@@ -6,6 +6,8 @@
 #ifndef __LIBFROG_RANDBYTES_H__
 #define __LIBFROG_RANDBYTES_H__
 
+#include <stdint.h>
+
 extern uint8_t randbytes_test_buf[];
 
 #endif /* __LIBFROG_RANDBYTES_H__ */
-- 
2.25.1


  reply	other threads:[~2023-09-26  7:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  7:14 [PATCH 0/1] Fix cross-compilation issue with randbytes Krzesimir Nowak
2023-09-26  7:14 ` Krzesimir Nowak [this message]
2023-09-26 14:41   ` [PATCH 1/1] libfrog: " Darrick J. Wong
2023-09-26 21:28     ` Dave Chinner
2023-10-03 11:15     ` Carlos Maiolino
2023-10-11 11:34       ` Krzesimir Nowak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926071432.51866-2-knowak@microsoft.com \
    --to=qdlacz@gmail.com \
    --cc=knowak@microsoft.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).