From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/1] xfs/270: update commit id for _fixed_by tag.
Date: Fri, 29 Sep 2023 10:27:16 -0700 [thread overview]
Message-ID: <20230929172716.GA21283@frogsfrogsfrogs> (raw)
In-Reply-To: <20230929052259.7umlz236g3o4su6r@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Fri, Sep 29, 2023 at 01:22:59PM +0800, Zorro Lang wrote:
> On Mon, Sep 25, 2023 at 02:42:56PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Update the commit id in the _fixed_by tag now that we've merged the
> > kernel fix.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > tests/xfs/270 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> > diff --git a/tests/xfs/270 b/tests/xfs/270
> > index 7d4e1f6a87..4e4f767dc1 100755
> > --- a/tests/xfs/270
> > +++ b/tests/xfs/270
> > @@ -17,7 +17,7 @@ _begin_fstest auto quick mount
> >
> > # real QA test starts here
> > _supported_fs xfs
> > -_fixed_by_kernel_commit xxxxxxxxxxxx \
> > +_fixed_by_kernel_commit 74ad4693b647 \
> > "xfs: fix log recovery when unknown rocompat bits are set"
>
> This patch is good to me, but we have more xfs cases have fixed commit which
> have been merged:
>
> $ grep -rsni xxxxxxxx tests/xfs|grep _fixed
> tests/xfs/600:23:_fixed_by_git_commit kernel XXXXXXXXXXXXX \
> tests/xfs/557:21:_fixed_by_kernel_commit XXXXXXXXXXXX \
> tests/xfs/270:20:_fixed_by_kernel_commit xxxxxxxxxxxx \
>
> xfs/600: cfa2df68b7ce xfs: fix an agbno overflow in __xfs_getfsmap_datadev
> xfs/557: 817644fa4525 xfs: get root inode correctly at bulkstat
>
> Do you want to fix them in one patch, or you hope to merge this
> patch at first?
Eh, I'll just resubmit with all three.
--D
> Thanks,
> Zorro
>
>
> > # skip fs check because superblock contains unknown ro-compat features
> > _require_scratch_nocheck
> >
>
next prev parent reply other threads:[~2023-09-29 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 21:42 [PATCHSET v2 0/1] fstests: fix ro mounting with unknown rocompat features Darrick J. Wong
2023-09-25 21:42 ` [PATCH 1/1] xfs/270: update commit id for _fixed_by tag Darrick J. Wong
2023-09-29 5:22 ` Zorro Lang
2023-09-29 17:27 ` Darrick J. Wong [this message]
2023-09-29 17:28 ` [PATCH v2.1 1/1] xfs/{270,557,600}: " Darrick J. Wong
2023-10-01 11:51 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929172716.GA21283@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).