From: Carlos Maiolino <cem@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCHSET v26.2 0/3] xfsprogs: force rebuilding of metadata
Date: Tue, 3 Oct 2023 13:33:34 +0200 [thread overview]
Message-ID: <20231003113334.zi7p7c77pqvesmfb@andromeda> (raw)
In-Reply-To: <169567912436.2320149.9404820627184014976.stgit@frogsfrogsfrogs>
On Mon, Sep 25, 2023 at 02:58:44PM -0700, Darrick J. Wong wrote:
> Hi all,
>
> This patchset adds a new IFLAG to the scrub ioctl so that userspace can
> force a rebuild of an otherwise consistent piece of metadata. This will
> eventually enable the use of online repair to relocate metadata during a
> filesystem reorganization (e.g. shrink). For now, it facilitates stress
> testing of online repair without needing the debugging knobs to be
> enabled.
Series look fine, although it requires a libxfs-sync to v6.6 before it can be
applied/tested.
Once I do a libxfs sync for v6.6 I'll apply/test this series.
By now, consider it a conditional RwB :)
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Carlos
>
> If you're going to start using this code, I strongly recommend pulling
> from my git trees, which are linked below.
>
> This has been running on the djcloud for months with no problems. Enjoy!
> Comments and questions are, as always, welcome.
>
> --D
>
> kernel git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-force-rebuild
>
> xfsprogs git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=repair-force-rebuild
>
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=repair-force-rebuild
> ---
> io/scrub.c | 24 ++++++++++++++-------
> man/man8/xfs_io.8 | 3 +++
> scrub/phase1.c | 28 ++++++++++++++++++++++++
> scrub/scrub.c | 61 ++++++++++++++++++++++++++++-------------------------
> scrub/scrub.h | 1 +
> scrub/xfs_scrub.c | 3 +++
> scrub/xfs_scrub.h | 1 +
> 7 files changed, 84 insertions(+), 37 deletions(-)
>
prev parent reply other threads:[~2023-10-03 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <iq6M2jOFTA7tpkemhj2B-jYNUxbdZWyn_T3zy7D3OK-XjdJMLzOaQp_x201-WWr0NRp1s5vaAspRGyQm7l2hqQ==@protonmail.internalid>
2023-09-25 21:58 ` [PATCHSET v26.2 0/3] xfsprogs: force rebuilding of metadata Darrick J. Wong
2023-09-25 21:58 ` [PATCH 1/3] xfs_io: support passing the FORCE_REBUILD flag to online repair Darrick J. Wong
2023-09-25 21:58 ` [PATCH 2/3] xfs_scrub: don't retry unsupported optimizations Darrick J. Wong
2023-09-25 21:59 ` [PATCH 3/3] xfs_scrub: try to use XFS_SCRUB_IFLAG_FORCE_REBUILD Darrick J. Wong
2023-10-03 11:33 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003113334.zi7p7c77pqvesmfb@andromeda \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).