From: Carlos Maiolino <cem@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] libxfs: use XFS_IGET_CREATE when creating new files
Date: Thu, 5 Oct 2023 14:35:56 +0200 [thread overview]
Message-ID: <20231005123556.yt4a6pju4fxisa77@andromeda> (raw)
In-Reply-To: <169454759296.3539425.5228393276062246709.stgit@frogsfrogsfrogs>
On Tue, Sep 12, 2023 at 12:39:52PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Use this flag to check that newly allocated inodes are, in fact,
> unallocated. This matches the kernel, and prevents userspace programs
> from making latent corruptions worse by unintentionally crosslinking
> files.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Carlos
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> libxfs/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/libxfs/util.c b/libxfs/util.c
> index e7d3497ec96..8f79b0cd17b 100644
> --- a/libxfs/util.c
> +++ b/libxfs/util.c
> @@ -260,7 +260,7 @@ libxfs_init_new_inode(
> unsigned int flags;
> int error;
>
> - error = libxfs_iget(tp->t_mountp, tp, ino, 0, &ip);
> + error = libxfs_iget(tp->t_mountp, tp, ino, XFS_IGET_CREATE, &ip);
> if (error != 0)
> return error;
> ASSERT(ip != NULL);
>
next prev parent reply other threads:[~2023-10-05 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 19:39 [PATCHSET 0/6] xfsprogs: minor fixes Darrick J. Wong
2023-09-12 19:39 ` [PATCH 1/6] libfrog: fix overly sleep workqueues Darrick J. Wong
2023-09-13 12:41 ` Carlos Maiolino
2023-10-05 12:34 ` Carlos Maiolino
2023-09-12 19:39 ` [PATCH 2/6] libfrog: don't fail on XFS_FSOP_GEOM_FLAGS_NREXT64 in xfrog_bulkstat_single5 Darrick J. Wong
2023-09-13 12:50 ` Carlos Maiolino
2023-10-05 12:34 ` Carlos Maiolino
2023-09-12 19:39 ` [PATCH 3/6] libxfs: use XFS_IGET_CREATE when creating new files Darrick J. Wong
2023-09-13 12:58 ` Carlos Maiolino
2023-09-14 18:24 ` Bill O'Donnell
2023-10-05 12:35 ` Carlos Maiolino [this message]
2023-09-12 19:39 ` [PATCH 4/6] xfs_scrub: actually return errno from check_xattr_ns_names Darrick J. Wong
2023-09-13 13:00 ` Carlos Maiolino
2023-10-05 12:36 ` Carlos Maiolino
2023-09-12 19:40 ` [PATCH 5/6] xfs_repair: set aformat and anextents correctly when clearing the attr fork Darrick J. Wong
2023-09-13 13:02 ` Carlos Maiolino
2023-09-14 18:25 ` Bill O'Donnell
2023-10-05 12:37 ` Carlos Maiolino
2023-09-12 19:40 ` [PATCH 6/6] libxfs: fix atomic64_t detection on x86 32-bit architectures Darrick J. Wong
2023-09-12 19:47 ` [PATCH v1.1 " Darrick J. Wong
2023-09-13 13:22 ` Carlos Maiolino
2023-09-14 18:26 ` Bill O'Donnell
2023-10-05 12:45 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005123556.yt4a6pju4fxisa77@andromeda \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).