Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Daan De Meyer <daan.j.demeyer@gmail.com>, linux-xfs@vger.kernel.org
Subject: Re: mkfs.xfs with --protofile does not copy extended attributes into the generated filesystem
Date: Thu, 5 Oct 2023 22:04:51 -0700	[thread overview]
Message-ID: <20231006050451.GQ21298@frogsfrogsfrogs> (raw)
In-Reply-To: <ZR+OtcVIsVrJeqMO@dread.disaster.area>

On Fri, Oct 06, 2023 at 03:36:05PM +1100, Dave Chinner wrote:
> On Thu, Oct 05, 2023 at 09:22:50PM -0700, Darrick J. Wong wrote:
> > On Fri, Oct 06, 2023 at 08:27:54AM +1100, Dave Chinner wrote:
> > > On Thu, Oct 05, 2023 at 10:37:34AM +0200, Daan De Meyer wrote:
> > > > Hi,
> > > > 
> > > > It seems using --protofile ignores any extended attributes set on
> > > > source files. I would like to generate an XFS filesystem using
> > > > --protofile where extended attributes are copied from the source files
> > > > into the generated filesystem. Any way to make this happen with
> > > > --protofile?
> > > 
> > > mkfs.xfs doesn't have a '--protofile' option. It has a '-p <file>'
> > > option for specifying a protofile - is that what you mean?
> > 
> > While we're on the topic, would it also be useful to have a -p switch
> > that would copy the fsxattr options as well?
> 
> If protofile support is going to be extended then supporting
> everything that can be read/set through generic kernel interfaces
> would be appropriate...
> 
> But I'm not convinced that we should extend protofile support
> because mounting the filesytsem and running rsync, xfs_restore, etc
> can already do all this stuffi with no development work necessary...

rsync doesn't support copying the fsxattr data (though it does support
extended attributes), and iirc xfsdump can only do entire filesystems,
right?

--D

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com

  reply	other threads:[~2023-10-06  5:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05  8:37 mkfs.xfs with --protofile does not copy extended attributes into the generated filesystem Daan De Meyer
2023-10-05 21:27 ` Dave Chinner
2023-10-06  4:22   ` Darrick J. Wong
2023-10-06  4:36     ` Dave Chinner
2023-10-06  5:04       ` Darrick J. Wong [this message]
2023-10-06  7:24         ` Daan De Meyer
2023-10-06 18:57           ` Darrick J. Wong
2023-10-09  9:59             ` Daan De Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006050451.GQ21298@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=daan.j.demeyer@gmail.com \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox