From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, john.g.garry@oracle.com
Subject: Re: [PATCH 7/9] xfs: caller perag always supplied to xfs_alloc_vextent_near_bno
Date: Thu, 5 Oct 2023 22:59:05 -0700 [thread overview]
Message-ID: <20231006055905.GW21298@frogsfrogsfrogs> (raw)
In-Reply-To: <20231004001943.349265-8-david@fromorbit.com>
On Wed, Oct 04, 2023 at 11:19:41AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> So we don't need to conditionally grab the perag anymore.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/libxfs/xfs_alloc.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index 289b54911b05..3190c8204903 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -3686,7 +3686,7 @@ xfs_alloc_vextent_exact_bno(
> * Allocate an extent as close to the target as possible. If there are not
> * viable candidates in the AG, then fail the allocation.
> *
> - * Caller may or may not have a per-ag reference in args->pag.
> + * Caller is expected to hold a per-ag reference in args->pag.
"Caller must hold..." ?
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> */
> int
> xfs_alloc_vextent_near_bno(
> @@ -3695,14 +3695,12 @@ xfs_alloc_vextent_near_bno(
> {
> struct xfs_mount *mp = args->mp;
> xfs_agnumber_t minimum_agno;
> - bool needs_perag = args->pag == NULL;
> uint32_t alloc_flags = 0;
> int error;
>
> - if (!needs_perag)
> - ASSERT(args->pag->pag_agno == XFS_FSB_TO_AGNO(mp, target));
> + ASSERT(args->pag->pag_agno == XFS_FSB_TO_AGNO(mp, target));
>
> - args->agno = XFS_FSB_TO_AGNO(mp, target);
> + args->agno = args->pag->pag_agno;
> args->agbno = XFS_FSB_TO_AGBNO(mp, target);
>
> trace_xfs_alloc_vextent_near_bno(args);
> @@ -3715,14 +3713,11 @@ xfs_alloc_vextent_near_bno(
> return error;
> }
>
> - if (needs_perag)
> - args->pag = xfs_perag_grab(mp, args->agno);
> -
> error = xfs_alloc_vextent_prepare_ag(args, alloc_flags);
> if (!error && args->agbp)
> error = xfs_alloc_ag_vextent_near(args, alloc_flags);
>
> - return xfs_alloc_vextent_finish(args, minimum_agno, error, needs_perag);
> + return xfs_alloc_vextent_finish(args, minimum_agno, error, false);
> }
>
> /* Ensure that the freelist is at full capacity. */
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-10-06 5:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 0:19 [RFC PATCH 0/9] xfs: push perags further into allocation routines Dave Chinner
2023-10-04 0:19 ` [PATCH 1/9] xfs: split xfs_bmap_btalloc_at_eof() Dave Chinner
2023-10-04 23:41 ` Darrick J. Wong
2023-10-05 9:41 ` Christoph Hellwig
2023-10-04 0:19 ` [PATCH 2/9] xfs: contiguous EOF allocation across AGs Dave Chinner
2023-10-05 9:43 ` Christoph Hellwig
2023-10-06 5:27 ` Darrick J. Wong
2023-10-04 0:19 ` [PATCH 3/9] xfs: select the AG with the largest contiguous space Dave Chinner
2023-10-05 9:45 ` Christoph Hellwig
2023-10-05 9:46 ` Christoph Hellwig
2023-10-24 16:25 ` Darrick J. Wong
2023-10-04 0:19 ` [PATCH 4/9] xfs: push the perag outwards in initial allocation Dave Chinner
2023-10-05 11:57 ` Christoph Hellwig
2023-10-04 0:19 ` [PATCH 5/9] xfs: aligned EOF allocations don't need to scan AGs anymore Dave Chinner
2023-10-05 11:59 ` Christoph Hellwig
2023-10-06 5:55 ` Darrick J. Wong
2023-10-04 0:19 ` [PATCH 6/9] xfs: use agno/agbno in xfs_alloc_vextent functions Dave Chinner
2023-10-05 12:02 ` Christoph Hellwig
2023-10-06 5:56 ` Darrick J. Wong
2023-10-04 0:19 ` [PATCH 7/9] xfs: caller perag always supplied to xfs_alloc_vextent_near_bno Dave Chinner
2023-10-05 12:02 ` Christoph Hellwig
2023-10-06 5:59 ` Darrick J. Wong [this message]
2023-10-04 0:19 ` [PATCH 8/9] xfs: collapse near and exact bno allocation Dave Chinner
2023-10-05 12:03 ` Christoph Hellwig
2023-10-06 6:01 ` Darrick J. Wong
2023-10-04 0:19 ` [PATCH 9/9] xfs: return -ENOSPC rather than NULLFSBLOCK from allocation functions Dave Chinner
2023-10-05 12:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006055905.GW21298@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=john.g.garry@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).