From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Subject: handle nimaps=0 from xfs_bmapi_write
Date: Mon, 9 Oct 2023 12:30:19 +0200 [thread overview]
Message-ID: <20231009103020.230639-1-hch@lst.de> (raw)
Hi all,
I've recently been playing around with re-enabling delayed
allocations on the RT subvolume (for the rextentsize=1 case), and ran
into an interesting bug where fsx unexpectedly returned -ENOSPC when
testing this code on top of Darrick's rtgroups code.
It turns out that this is because xfs_alloc_file_space does not retry
when xfs_bmapi_write returns 0 with *nimaps = 0, which can happen if the
allocator can't fill the entire space from the beginning of a delalloc
extent to the start of the actually requested range in the call to
xfs_bmapi_write.
next reply other threads:[~2023-10-09 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 10:30 Christoph Hellwig [this message]
2023-10-09 10:30 ` [PATCH] xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space Christoph Hellwig
2023-10-09 16:27 ` Darrick J. Wong
2023-10-10 7:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009103020.230639-1-hch@lst.de \
--to=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).