From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 976A2CD98E9 for ; Wed, 11 Oct 2023 03:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344988AbjJKDRQ (ORCPT ); Tue, 10 Oct 2023 23:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344915AbjJKDRQ (ORCPT ); Tue, 10 Oct 2023 23:17:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD3291 for ; Tue, 10 Oct 2023 20:17:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B577FC433C7; Wed, 11 Oct 2023 03:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696994234; bh=V79xg3KCT1tQ1nUFhjdvmntXaR26mB3eZLNiDgp6tK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GpdinCFPfQ2tNBR1EQsWXu0GsoKYcNSFmUGLV2kS7QtJZU3Ciq1pDzaWabKVFjxax mpG7wRfKW03+bDcIYcn+hfPg76cHgpzN/T8v8F/tV8vlVA54fLenAjMgoNz01elX3C R2h55LGMm+s8+x96CgLZXCgQXRHaaHmRdF1LFMFgg9hObPMSBwa5JQtn3cDc8eqtTJ EkkRzsXNRoSJMxkhSg9AiRgkAtU1L/mZIhbo0L2tGb5rcppy1OQBNE/8SUIxLWAas7 0V1/LJ4tiEh7QA1WTxDxvW+IbABq3Zens9UGwo/mEQdmveem1jmGX0cjliQD2Fhs2C ynEUp9q/6aqcQ== Date: Tue, 10 Oct 2023 20:17:12 -0700 From: Eric Biggers To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, fsverity@lists.linux.dev, djwong@kernel.org, david@fromorbit.com, dchinner@redhat.com Subject: Re: [PATCH v3 08/28] fsverity: pass Merkle tree block size to ->read_merkle_tree_page() Message-ID: <20231011031712.GC1185@sol.localdomain> References: <20231006184922.252188-1-aalbersh@redhat.com> <20231006184922.252188-9-aalbersh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006184922.252188-9-aalbersh@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Oct 06, 2023 at 08:49:02PM +0200, Andrey Albershteyn wrote: > diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h > index 6514ed6b09b4..252b2668894c 100644 > --- a/include/linux/fsverity.h > +++ b/include/linux/fsverity.h > @@ -103,7 +103,8 @@ struct fsverity_operations { > */ > struct page *(*read_merkle_tree_page)(struct inode *inode, > pgoff_t index, > - unsigned long num_ra_pages); > + unsigned long num_ra_pages, > + u8 log_blocksize); XFS doesn't actually use this, though. In patch 10 you add read_merkle_tree_block, and that is used instead. So this patch seems unnecessary. - Eric