Re: [PATCH v3 15/28] xfs: introduce workqueue for post read IO work

Andrey Albershteyn
2023-10-16T12:38:15Z

On 2023-10-11 11:55:58, Darrick J. Wong wrote:
> On Fri, Oct 06, 2023 at 08:49:09PM +0200, Andrey Albershteyn wrote:
> > As noted by Dave there are two problems with using fs-verity's
> > workqueue in XFS:
> >
> > 1. High priority workqueues are used within XFS to ensure that data
> > IO completion cannot stall processing of journal IO completions.
> > Hence using a WQ_HIGHPRI workqueue directly in the user data IO
> > path is a potential filesystem livelock/deadlock vector.
> >
> > 2. The fsverity workqueue is global - it creates a cross-filesystem
> > contention point.
> >
> > This patch adds per-filesystem, per-cpu workqueue for fsverity
> > work.
>
> If we ever want to implement compression and/or fscrypt, can we use this
> pread workqueue for that too?

I think yes.

> Sounds good to me...
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks!

--
- Andrey