Re: [PATCH v3 06/28] fsverity: add drop_page() callout

Eric Biggers
2023-10-11T03:06:52Z

On Fri, Oct 06, 2023 at 08:49:00PM +0200, Andrey Albershteyn wrote:
> Allow filesystem to make additional processing on verified pages
> instead of just dropping a reference. This will be used by XFS for
> internal buffer cache manipulation in further patches. The btrfs,
> ext4, and f2fs just drop the reference.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@redhat.com>
> ---
> fs/verity/read_metadata.c | 4 ++--
> fs/verity/verify.c | 6 +++---
> include/linux/fsverity.h | 33 +++++++++++++++++++++++++++++++++
> 3 files changed, 38 insertions(+), 5 deletions(-)

The changes from this patch all get superseded by the changes in patch 10 that
make it drop_block instead. So that puts this patch in a weird position where
there's no real point in reviewing it alone. Maybe fold it into patch 10? I
suppose you're trying not to make that patch too large, but perhaps there's a
better way to split it up.

- Eric