Re: [PATCH v3 07/28] fsverity: always use bitmap to track verified status

Christoph Hellwig
2023-10-17T05:57:52Z

On Thu, Oct 12, 2023 at 12:27:46AM -0700, Eric Biggers wrote:
> Currently there are two options: PG_checked and the separate bitmap. I'm not
> yet convinced that removing the support for the PG_checked method is a good
> change. PG_checked is a nice solution for the cases where it can be used; it
> requires no extra memory, no locking, and has no max file size. Also, this
> change seems mostly orthogonal to what you're actually trying to accomplish.

Given that willy has been on a (IMHO reasonable) quest to kill off
as many as possible page flags I'd really like to seize the opportunity
and kill PageCheck in fsverity. How big are the downsides of the bitmap
vs using the page flags, and do they matter in practice?