Re: [PATCH v3 08/28] fsverity: pass Merkle tree block size to ->read_merkle_tree_page()

Eric Biggers
2023-10-11T03:17:17Z

On Fri, Oct 06, 2023 at 08:49:02PM +0200, Andrey Albershteyn wrote:
> diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h
> index 6514ed6b09b4..252b2668894c 100644
> --- a/include/linux/fsverity.h
> +++ b/include/linux/fsverity.h
> @@ -103,7 +103,8 @@ struct fsverity_operations {
> */
> struct page *(*read_merkle_tree_page)(struct inode *inode,
> pgoff_t index,
> - unsigned long num_ra_pages);
> + unsigned long num_ra_pages,
> + u8 log_blocksize);

XFS doesn't actually use this, though. In patch 10 you add
read_merkle_tree_block, and that is used instead.

So this patch seems unnecessary.

- Eric