From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Catherine Hoang <catherine.hoang@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3] xfs: allow read IO and FICLONE to run concurrently
Date: Thu, 12 Oct 2023 08:02:31 -0700 [thread overview]
Message-ID: <20231012150231.GE21298@frogsfrogsfrogs> (raw)
In-Reply-To: <ZSevmga8j3dNl34J@infradead.org>
On Thu, Oct 12, 2023 at 01:34:34AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 11, 2023 at 06:08:45PM -0700, Catherine Hoang wrote:
> > Clone operations and read IO do not change any data in the source file, so they
> > should be able to run concurrently. Demote the exclusive locks taken by FICLONE
> > to shared locks to allow reads while cloning. While a clone is in progress,
> > writes will take the IOLOCK_EXCL, so they block until the clone completes.
>
> FYI, the first two lines are too long for the normal commit log format.
>
> Can you provide a justification for the change, i.e. worksloads for
> which this matters, and what metrics are improved?
Catherine started with this,
https://lore.kernel.org/linux-xfs/8911B94D-DD29-4D6E-B5BC-32EAF1866245@oracle.com/
and the rest of us whittled it down to the single patch you see here.
Sections 1-2 are still relevant; S3 was the path not taken.
The commit message should Link: to that.
--D
next prev parent reply other threads:[~2023-10-12 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 1:08 [PATCH v3] xfs: allow read IO and FICLONE to run concurrently Catherine Hoang
2023-10-12 6:26 ` Darrick J. Wong
2023-10-12 8:34 ` Christoph Hellwig
2023-10-12 15:02 ` Darrick J. Wong [this message]
2023-10-12 15:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012150231.GE21298@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox