From: Christoph Hellwig <hch@lst.de>
To: Jan Stancek <jstancek@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
djwong@kernel.org, willy@infradead.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] iomap: fix short copy in iomap_write_iter()
Date: Wed, 18 Oct 2023 17:52:20 +0200 [thread overview]
Message-ID: <20231018155220.GA26845@lst.de> (raw)
In-Reply-To: <CAASaF6xHTv6iZd5ttHOJ_M=hpjaGZOnUCGSHkbGy_yLbe2G8nw@mail.gmail.com>
On Wed, Oct 18, 2023 at 04:32:19PM +0200, Jan Stancek wrote:
> On Wed, Oct 18, 2023 at 2:22 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > On Wed, Oct 18, 2023 at 10:24:20AM +0200, Jan Stancek wrote:
> > > Make next iteration retry with amount of bytes we managed to copy.
> >
> > The observation and logic fix look good. But I wonder if simply
> > using a goto instead of the extra variable would be a tad cleaner?
> > Something like this?
>
> Looks good to me. Would you be OK if I re-posted it as v2 with your
> Signed-off-by added?
Please skip my signoff. This is really your work and I just a very
cosmetic suggestion.
next prev parent reply other threads:[~2023-10-18 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 8:24 [PATCH] iomap: fix short copy in iomap_write_iter() Jan Stancek
2023-10-18 12:22 ` Christoph Hellwig
2023-10-18 14:32 ` Jan Stancek
2023-10-18 15:52 ` Christoph Hellwig [this message]
2023-10-18 18:32 ` [PATCH v2] " Jan Stancek
2023-10-18 23:30 ` Darrick J. Wong
2023-10-19 4:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018155220.GA26845@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=jstancek@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).