From: "Darrick J. Wong" <djwong@kernel.org>
To: Anthony Iliopoulos <ailiop@suse.com>
Cc: linux-xfs@vger.kernel.org,
"Holger Hoffstätte" <holger@applied-asynchrony.com>
Subject: Re: [PATCH] xfs: fix again select in kconfig XFS_ONLINE_SCRUB_STATS
Date: Mon, 6 Nov 2023 14:27:56 -0800 [thread overview]
Message-ID: <20231106222756.GK1205143@frogsfrogsfrogs> (raw)
In-Reply-To: <20231105192318.121783-1-ailiop@suse.com>
On Sun, Nov 05, 2023 at 08:23:18PM +0100, Anthony Iliopoulos wrote:
> Commit 57c0f4a8ea3a attempted to fix the select in the kconfig entry
> XFS_ONLINE_SCRUB_STATS by selecting XFS_DEBUG, but the original
> intention was to select DEBUG_FS, since the feature relies on debugfs to
> export the related scrub statistics.
>
> Fixes: 57c0f4a8ea3a ("xfs: fix select in config XFS_ONLINE_SCRUB_STATS")
>
> Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com>
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Yep. Sorry about that garbledygook.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index ed0bc8cbc703..567fb37274d3 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
> bool "XFS online metadata check usage data collection"
> default y
> depends on XFS_ONLINE_SCRUB
> - select XFS_DEBUG
> + select DEBUG_FS
> help
> If you say Y here, the kernel will gather usage data about
> the online metadata check subsystem. This includes the number
> --
> 2.42.0
>
prev parent reply other threads:[~2023-11-06 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 19:23 [PATCH] xfs: fix again select in kconfig XFS_ONLINE_SCRUB_STATS Anthony Iliopoulos
2023-11-05 22:51 ` Dave Chinner
2023-11-06 22:27 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106222756.GK1205143@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=ailiop@suse.com \
--cc=holger@applied-asynchrony.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox