From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] repair: fix process_rt_rec_dups
Date: Thu, 9 Nov 2023 05:44:39 +0100 [thread overview]
Message-ID: <20231109044439.GA28458@lst.de> (raw)
In-Reply-To: <20231108192048.GX1205143@frogsfrogsfrogs>
On Wed, Nov 08, 2023 at 11:20:48AM -0800, Darrick J. Wong wrote:
> Correct. The scan_bmapbt query is in units of rtblocks. For
> rextsize==1 there's no error here; for rextsize > 2, the
> search_rt_dup_extent queries probe well past the end of the rt_ext_tree
> structure, so they never find the duplicate extents.
>
> This /does/ explain why the one time I tried crosslinking rt extents I
> was surprised that xfs_repair didn't seem to detect them consistently.
>
> Hmm, let me go clean all that up in to a TOTALLY UNTESTED patch.
This does looks sensible, but I suspect it makes more sense to do this
after merging the series to introduce xfs_rtxnum_t and friends in the
RT code. I'll cook up a patch to just fix scan_bmapbt for now.
prev parent reply other threads:[~2023-11-09 4:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 17:53 [PATCH] repair: fix process_rt_rec_dups Christoph Hellwig
2023-11-08 18:08 ` Darrick J. Wong
2023-11-08 18:21 ` Christoph Hellwig
2023-11-08 19:20 ` Darrick J. Wong
2023-11-09 4:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109044439.GA28458@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox