From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB699C4332F for ; Thu, 9 Nov 2023 04:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232242AbjKIEop (ORCPT ); Wed, 8 Nov 2023 23:44:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbjKIEop (ORCPT ); Wed, 8 Nov 2023 23:44:45 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBB002584 for ; Wed, 8 Nov 2023 20:44:42 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id A4D6767373; Thu, 9 Nov 2023 05:44:39 +0100 (CET) Date: Thu, 9 Nov 2023 05:44:39 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH] repair: fix process_rt_rec_dups Message-ID: <20231109044439.GA28458@lst.de> References: <20231108175320.500847-1-hch@lst.de> <20231108180827.GW1205143@frogsfrogsfrogs> <20231108182101.GA17121@lst.de> <20231108192048.GX1205143@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108192048.GX1205143@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Nov 08, 2023 at 11:20:48AM -0800, Darrick J. Wong wrote: > Correct. The scan_bmapbt query is in units of rtblocks. For > rextsize==1 there's no error here; for rextsize > 2, the > search_rt_dup_extent queries probe well past the end of the rt_ext_tree > structure, so they never find the duplicate extents. > > This /does/ explain why the one time I tried crosslinking rt extents I > was surprised that xfs_repair didn't seem to detect them consistently. > > Hmm, let me go clean all that up in to a TOTALLY UNTESTED patch. This does looks sensible, but I suspect it makes more sense to do this after merging the series to introduce xfs_rtxnum_t and friends in the RT code. I'll cook up a patch to just fix scan_bmapbt for now.