From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] repair: fix the call to search_rt_dup_extent in scan_bmapbt
Date: Thu, 9 Nov 2023 17:14:54 +0100 [thread overview]
Message-ID: <20231109161454.GA5453@lst.de> (raw)
In-Reply-To: <20231109161319.GF1205143@frogsfrogsfrogs>
On Thu, Nov 09, 2023 at 08:13:19AM -0800, Darrick J. Wong wrote:
> In the longer run: whenever the libxfs 6.7 sync hits the list, I'll be
> ready to go with a pair of broader patches to fix all the confusing /
> incorrect units and variable names in xfs_repair. This ought to get
> merged to xfsprogs 6.6.
Yes, please!
FYI, I've done a prototype of annotation the rxtnumber_t with __nocast
in the kernel, and except for the ugliness in casting all the 0 values
it actually looks pretty nice. I hope with the extra work Luc promised
we can actually annotate our non-byte offset/bno/len fields with it and
get real type checking for them.
prev parent reply other threads:[~2023-11-09 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 16:02 [PATCH] repair: fix the call to search_rt_dup_extent in scan_bmapbt Christoph Hellwig
2023-11-09 16:13 ` Darrick J. Wong
2023-11-09 16:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109161454.GA5453@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox