From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: zlang@redhat.com, guan@eryu.me, david@fromorbit.com,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: test unlinked inode list repair on demand
Date: Thu, 9 Nov 2023 20:46:46 -0800 [thread overview]
Message-ID: <20231110044646.GE1203404@frogsfrogsfrogs> (raw)
In-Reply-To: <ZUxwoLoy2D/CIUbE@infradead.org>
On Wed, Nov 08, 2023 at 09:39:44PM -0800, Christoph Hellwig wrote:
> > +# Modify as appropriate.
>
> Btw, why do we keep adding this pointless boilerplate everywhere?
Oops. It comes from the ./new output, but I guess I am a bit lazy about
removing it. :(
> > +_supported_fs generic
>
> I think this should be xfs only.
Changed.
> > +source ./common/filter
> > +source ./common/fuzzy
> > +source ./common/quota
>
> When did we switch from using . to source other shell files
> to "source"? Just curious.
Habit of mine. vim colors and bolds "source" nicely, which it doesn't
do for dot.
> > +
> > +# real QA test starts here
> > +
> > +# Modify as appropriate.
> > +_supported_fs generic
>
> xfs again.
Changed again.
--D
next prev parent reply other threads:[~2023-11-10 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 21:29 [PATCHSET v3 0/2] fstests: reload entire iunlink lists Darrick J. Wong
2023-11-08 21:29 ` [PATCH 1/2] common: make helpers for ttyprintk usage Darrick J. Wong
2023-11-09 5:36 ` Christoph Hellwig
2023-11-08 21:29 ` [PATCH 2/2] xfs: test unlinked inode list repair on demand Darrick J. Wong
2023-11-09 5:39 ` Christoph Hellwig
2023-11-10 4:46 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-13 17:08 [PATCHSET v4 0/2] fstests: reload entire iunlink lists Darrick J. Wong
2023-11-13 17:08 ` [PATCH 2/2] xfs: test unlinked inode list repair on demand Darrick J. Wong
2023-11-16 14:42 ` Zorro Lang
2023-11-16 17:30 [PATCHSET v5 0/2] fstests: reload entire iunlink lists Darrick J. Wong
2023-11-16 17:30 ` [PATCH 2/2] xfs: test unlinked inode list repair on demand Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110044646.GE1203404@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox